On 16/05/12 12:42, Mike Frysinger wrote:
On Tue, May 15, 2012 at 8:45 PM, Greg Ungerer<g...@snapgear.com> wrote:
On 16/05/12 01:57, Mike Frysinger wrote:
On Tue, May 15, 2012 at 12:08 AM,<g...@snapgear.com> áwrote:
. make the struct uclinux_ram_map static
NAK: this breaks Blackfin systems. áwe specifically don't want this to
be static.
it should probably get a comment added above it saying as much.
A comment won't fix the sparse warning. You need a proper declaration.
perhaps, but marking it static to fix a warning that people rarely see
whilst simultaneously knowingly breaking an arch doesn't sound like
the correct trade off.
I agree, of course. It wasn't done to knowingly break an arch. But
the sparse warning can be fixed with a proper declaration, that
would avoid you having a local extern for it in
arch/blackfin/kernel/setup.c as well. Cleaner all round.
Regards
Greg
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: g...@snapgear.com
SnapGear Group, McAfee PHONE: +61 7 3435 2888
8 Gardner Close FAX: +61 7 3217 5323
Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com
_______________________________________________
uClinux-dev mailing list
uClinux-dev@uclinux.org
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by uclinux-dev@uclinux.org
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev
