On 13 December 2015 at 23:32, Greg Ungerer <g...@uclinux.org> wrote: > Hi Andrew, > > On 14/12/15 12:18, Andrew Cagney wrote: >> On 13 December 2015 at 19:43, Greg Ungerer <g...@uclinux.org> wrote: >>> Hi Andrew, >>> >>> On 12/12/15 03:03, Andrew Cagney wrote: >>>> I came up with the attached. The existing libgmp configuration in >>>> lib/Kconfig would need removing. >>> >>> I would suggest not bothering to make it a menu on its own. >>> And the config entry for LIB_LIBGMP_DISABLE_ASSEMBLY should >>> have a "depends on LIB_LIBGMP". >> >> I tried that. Consider: >> >> - target board is M5208EVB which isn't supported by libgmp's assembly files >> >> - libreswan requires libgmp so it's Kconfig includes a line to enable >> building libgmp >> >> So the developer uses menuconfig, selects "libreswan", and builds. >> >> Unfortunately it fails because the disable-assembly option needs to be >> set manually. >> >> Having it as a separate flag and not requiring LIB_LIBGMP made it >> possible to save it in the vendor config file regardless of LIB_LIBGMP >> status. > > But what user would set the disable assembler option correctly > when they don't even think they need libgmp? I don't think it > logically follows that it should be an always selectable option. > > >> idea's welcome. > > In your example above it is not the M5208EVB that is the selection > criteria. It is probably the fact that a ColdFire architecture CPU > is the target. > > Maybe make time setting would work better in this case. Have a look > in the lib/libssl/makefile for an example that has to solve a > similar problem.
Yea, that's along the lines of my plan B - put the matic closer to the problem in lib/libgmp/makefile. Thanks for the pointer. Andrew _______________________________________________ uClinux-dev mailing list uClinux-dev@uclinux.org http://mailman.uclinux.org/mailman/listinfo/uclinux-dev This message was resent by uclinux-dev@uclinux.org To unsubscribe see: http://mailman.uclinux.org/mailman/options/uclinux-dev
