On Tue, May 25, 2010 at 06:23, Oleg Nesterov wrote: > - arch/blackfin/kernel/ptrace.c:is_user_addr_valid() > needs mmap_sem around find_vma() > > The lockless access to mm->context.sram_list doesn't look > safe to me. > > If we add get_task_mm() - this protects us against > destroy_context() only. What is the tracee's sub-thread > does sys_sram_alloc() or sys_sram_free() in parallel?
i dont believe there are any code paths in UP systems where this would be a practical problem because sram_list is only updated by syscalls from userspace. we probably should add proper locking to this structure though. i'll open a tracker item about it, thanks ! -mike _______________________________________________ Uclinux-dist-devel mailing list Uclinux-dist-devel@blackfin.uclinux.org https://blackfin.uclinux.org/mailman/listinfo/uclinux-dist-devel
