Hi,
just wanted to point out that in way too many places the uDig code
eats away exceptions without even logging them.
As a result, a small error, a misconfiguration, goes totally unnoticed
and you get exceptions later, in strange places, that don't help
to debug the plugins you're writing.

Maybe adding (to the build) PMD and checkstyle with the right rules would help a great deal in this respect...

Cheers
Andrea

PS: for an example of what I mean, see:

package net.refractions.udig.printing.model.impl.ModelFactoryImpl#createBoxPrinterFromString(...) {
  try {
    ...
  } catch(Exception e) {
    return null; // AARGGHH!!!
  }
}

and to be sincere, some sanity check should be performed elsewhere too -> a
misconfiguration of a string by myself led to a totally hidden error, no log
or error whatosever telling me I was doing something wrong!

_______________________________________________
User-friendly Desktop Internet GIS (uDig)
http://udig.refractions.net
http://lists.refractions.net/mailman/listinfo/udig-devel

Reply via email to