I remember it was just prior to foss4g so it was hard to respond well. 

Here is the interesting bit:

> IMHO it would be fantastic to have additional bundle(s) for the MapEditor(s) 
> based on an AbstractMapEditor, one which extends 
> GraphicalEditorWithFlyoutPalette and an other one (old classic style) that 
> extends EditorPart. So the host application could decide which editor 
> (extension point) to use.
> 

The trouble is the team has moved on to the next topic; so we need to be really 
"tight" about collected feedback for these RFCs so we don't miss any important 
input such as you have now provided.

Right now a technical limitation prevents the definition of an abstract class 
to share code between the two implementations (as both want to extend a 
specific base class). I think we may be able to adjust things so we get two 
clear implementations (both extending the GEF classes but one can turn things 
off). It would not help with the "extra" dependency on GEF but it would allow 
you to continue your current look and feel.

The other trouble here is that we were looking for a way to help Jesse not 
maintain the current look and feel (with drop down combos in the toolbar). The 
code has been complicated to maintain; and we were not really impressed to have 
to write it to begin with; let alone continue to maintain it today. Indeed part 
of the motivation for this proposal is to migrate to something provided by 
Eclipse so we have less code in uDig to maintain.

So I think short term I can try and adjust the classes so we do not have 
duplication (as that is effecting development today); but if you have any plan 
for how you would like to proceed it would be good. The one good thing is that 
the tool extension point is available so we can process it form a number of 
places (even in a downstream RCP app) in order to control the currently used 
tool.

-- 
Jody Garnett


On Monday, 26 September 2011 at 5:26 PM, Frank Gasdorf wrote:

> Jody, Levi & List
> 
> I few weeks ago I posted some thoughts about a standalone MapEditor
> with GEF Actions vs. a "standard" MapEditor and a extended GEF
> MapEditor : "MapEditor GEF palette - some thoughts"
> http://permalink.gmane.org/gmane.comp.gis.udig.devel/18273
> 
> Please consider to take into account that a replacement wouldn't brake
> code but user "perception" in Standalone RCP, if the map has an other
> user behavior that the whole application around.
> 
> Thanks! I'll have a look at IRC, if somebody is around to chat about
> this topic ..
> 
> Cheers,
> Frank
> 2011/9/26 Jody Garnett <[email protected] 
> (mailto:[email protected])>
> > 
> > It is a good question:
> > 1) we have had the request to keep MapEditor in order to allow projects to 
> > proceed without the GEF dependency; this feedback did not arrive in time 
> > for the initial RFC and thus did not make it into the plan / budget. It is 
> > however technically possible (i.e. make another plugin that depends on GEF 
> > and contains MapEditorWithPalette)
> > 2) If we do keep both I would like to arrange for them to share code; 
> > however given the abstract class requirements that is not possible?
> > a) We could consider aggregation and have them both delegate but that feels 
> > a bit weak; it would allow handling of status area / tools and so on to be 
> > consistent
> > 3) If we do not keep both I would like to delete MapEditor; and rename 
> > MapEditorWithPalette so we are down to a single choice.
> > I suspect this is slowing up your "Tool Options" work and thus is something 
> > to sort out over the next day or two.
> > --
> > Jody Garnett
> > 
> > On Monday, 26 September 2011 at 4:24 PM, Levi Putna wrote:
> > 
> > Hey guys,
> > Quick question. We have MapEditorWithPalette and MapEditor, are we 
> > maintaining both? or is MapEditor deprecated?
> > --
> > Levi Putna
> > www.ozblog.com.au (http://www.ozblog.com.au)
> > _______________________________________________
> > User-friendly Desktop Internet GIS (uDig)
> > http://udig.refractions.net
> > http://lists.refractions.net/mailman/listinfo/udig-devel
> > 
> > 
> > _______________________________________________
> > User-friendly Desktop Internet GIS (uDig)
> > http://udig.refractions.net
> > http://lists.refractions.net/mailman/listinfo/udig-devel
> _______________________________________________
> User-friendly Desktop Internet GIS (uDig)
> http://udig.refractions.net
> http://lists.refractions.net/mailman/listinfo/udig-devel

_______________________________________________
User-friendly Desktop Internet GIS (uDig)
http://udig.refractions.net
http://lists.refractions.net/mailman/listinfo/udig-devel

Reply via email to