> Hey Jody, > > Tried out the enablement stuff today and found some issues: > > case 1: > - click on AOI view > - open Resource Properties > - java.lang.NullPointerException > at > org.eclipse.ui.actions.SelectionProviderAction.<init>(SelectionProviderAction.java:60) > at > org.eclipse.ui.dialogs.PropertyDialogAction.<init>(PropertyDialogAction.java:89) > at > net.refractions.udig.catalog.ui.internal.IGeoResourcePropertiesCommandHandler.execute(IGeoResourcePropertiesCommandHandler.java:52) > > >
Interesting, so the AOI view is not publishing a ISelectionProvider, so there is nothing for the Properties Dialog to open. Ideally I would like the menu item to to be disabled at that point. I am going to try the same visibleWhen trick (which I wanted a review of). I suspect it will fix both problems. > > > case 2: > - click on Feature Selection tool > - Open Resource Properties > - info popup shows with this msg, "No property pages for ." > - then after click of OK > - java.lang.NullPointerException > at > net.refractions.udig.catalog.ui.internal.IGeoResourcePropertiesCommandHandler.execute(IGeoResourcePropertiesCommandHandler.java:54) > at > org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:293) > > Thanks! > > > From: [email protected] > [mailto:[email protected]] On Behalf Of Nazareno Chan > Sent: Wednesday, 8 August 2012 9:16 AM > To: User-friendly Desktop Internet GIS > Subject: Re: [udig-devel] document view stage 2 pull request > > I’m checking this now as of writing, and can we ask another person to > review/accept the pull request? Since I think it would be biased for me to do > so since I did some of the changes. > > Thanks guys. J > > From: [email protected] > (mailto:[email protected]) > [mailto:[email protected]] On Behalf Of Jody Garnett > Sent: Wednesday, 8 August 2012 9:06 AM > To: User-friendly Desktop Internet GIS > Subject: [udig-devel] document view stage 2 pull request > > Stage 2 pull request is up: > > > > - https://github.com/uDig/udig-platform/pull/118 > > > > This is the next batch of changes for: > > > > http://udig.refractions.net/confluence/display/UDIG/Document+View > > > > This pull request is for stage 2 "Stage 2 General purpose implementation". > > > > This has three major changes: > > 1) PropertyPage for configuring document "hotlinks" (thanks for the review > Naz) > > 2) Fixed up how the Data > Service Properties and Data > Resource Properties > are opened > > - created a core expression property for IResolve so we can test for > "featureSource" etc... > > - used for both menu and property page visibleWhen settings > > 3) Fixed up the commands used to open "Service Properties" by making a custom > selection provider > > > > > Naz if you can check this over, I know this is just an step along the way to > completion - the the menu enablement stuff is cool. > > > > Moovida I would like to touch base with you for the final stage 4 pull > request, we should be a week or so away form that. > > > > -- > > Jody Garnett > > > > > > > > The contents of this email are confidential and may be subject to legal or > professional privilege and copyright. No representation is made that this > email is free of viruses or other defects. If you have received this > communication in error, you may not copy or distribute any part of it or > otherwise disclose its contents to anyone. Please advise the sender of your > incorrect receipt of this correspondence. > > > > The contents of this email are confidential and may be subject to legal or > professional privilege and copyright. No representation is made that this > email is free of viruses or other defects. If you have received this > communication in error, you may not copy or distribute any part of it or > otherwise disclose its contents to anyone. Please advise the sender of your > incorrect receipt of this correspondence. > _______________________________________________ > User-friendly Desktop Internet GIS (uDig) > http://udig.refractions.net > http://lists.refractions.net/mailman/listinfo/udig-devel > >
_______________________________________________ User-friendly Desktop Internet GIS (uDig) http://udig.refractions.net http://lists.refractions.net/mailman/listinfo/udig-devel
