Okay, thanks mate, ill update code with regards to the comments on the next pull request.
From: [email protected] [mailto:[email protected]] On Behalf Of Jody Garnett Sent: Friday, 31 August 2012 9:49 AM To: User-friendly Desktop Internet GIS Cc: Jody Garnett Subject: Re: [udig-devel] uDig - Pull Request for DocumentView RFC (first part of Stage 4) Morning Naz: I added several comments (on coding style) to that pull request; if you could kind look at those before this work is finished up. The only solid down check was documentation being added that is not referenced in toc.xml (and thus no shown to users). To help with this I have added a test case to the doc module which will: - fail if toc.xml refers to a file that is not there - fail if a page is referred to more than once in the toc.xml (although this may be allowed? so perhaps a warning) - fail if there are any files left over that are not mentioned in toc.xml Here is the output: toc.xml does not reference 'Attaching a document.rst' - add the following: <topic label="Attaching a document" href="EN//Attaching a document.rst"> </topic> toc.xml does not reference 'Configure hotlink attributes.rst' - add the following: <topic label="Configure hotlink attributes" href="EN//Configure hotlink attributes.rst"> </topic> toc.xml does not reference 'docguide.rst' - add the following: <topic label="docguide" href="EN//docguide/docguide.rst"> </topic> toc.xml does not reference 'sphinxSyntax.rst' - add the following: <topic label="sphinxSyntax" href="EN//docguide/sphinxSyntax.rst"> </topic> toc.xml does not reference 'Document view.rst' - add the following: <topic label="Document view" href="EN//Document view.rst"> </topic> toc.xml does not reference 'AddingLayersfromtheCatalogView.rst' - add the following: <topic label="AddingLayersfromtheCatalogView" href="EN//getting_started/walkthrough1/AddingLayersfromtheCatalogView.rst"> </topic> toc.xml does not reference 'ConnectingtoaWebMapServer.rst' - add the following: <topic label="ConnectingtoaWebMapServer" href="EN//getting_started/walkthrough1/ConnectingtoaWebMapServer.rst"> </topic> toc.xml does not reference 'ImportDirectlytoTheCatalog.rst' - add the following: <topic label="ImportDirectlytoTheCatalog" href="EN//getting_started/walkthrough1/ImportDirectlytoTheCatalog.rst"> </topic> toc.xml does not reference 'index.rst' - add the following: <topic label="index" href="EN//getting_started/walkthrough1/index.rst"> </topic> toc.xml does not reference 'InformationRequest.rst' - add the following: <topic label="InformationRequest" href="EN//getting_started/walkthrough1/InformationRequest.rst"> </topic> toc.xml does not reference 'InstallingandRunningTheuDigApplication.rst' - add the following: <topic label="InstallingandRunningTheuDigApplication" href="EN//getting_started/walkthrough1/InstallingandRunningTheuDigApplication.rst"> </topic> toc.xml does not reference 'Introduction.rst' - add the following: <topic label="Introduction" href="EN//getting_started/walkthrough1/Introduction.rst"> </topic> toc.xml does not reference 'OnlineDocumentationandTutorials.rst' - add the following: <topic label="OnlineDocumentationandTutorials" href="EN//getting_started/walkthrough1/OnlineDocumentationandTutorials.rst"> </topic> toc.xml does not reference 'Re-projection.rst' - add the following: <topic label="Re-projection" href="EN//getting_started/walkthrough1/Re-projection.rst"> </topic> toc.xml does not reference 'ThemedData.rst' - add the following: <topic label="ThemedData" href="EN//getting_started/walkthrough1/ThemedData.rst"> </topic> toc.xml does not reference 'TheWorkbench.rst' - add the following: <topic label="TheWorkbench" href="EN//getting_started/walkthrough1/TheWorkbench.rst"> </topic> toc.xml does not reference 'WebView.rst' - add the following: <topic label="WebView" href="EN//getting_started/walkthrough1/WebView.rst"> </topic> toc.xml does not reference 'WhattodoNext.rst' - add the following: <topic label="WhattodoNext" href="EN//getting_started/walkthrough1/WhattodoNext.rst"> </topic> toc.xml does not reference 'WorkingwithFiles.rst' - add the following: <topic label="WorkingwithFiles" href="EN//getting_started/walkthrough1/WorkingwithFiles.rst"> </topic> toc.xml does not reference 'ChangingSnappingBehavior.rst' - add the following: <topic label="ChangingSnappingBehavior" href="EN//getting_started/walkthrough2/ChangingSnappingBehavior.rst"> </topic> toc.xml does not reference 'CopyingContent.rst' - add the following: <topic label="CopyingContent" href="EN//getting_started/walkthrough2/CopyingContent.rst"> </topic> toc.xml does not reference 'CreateGeometry.rst' - add the following: <topic label="CreateGeometry" href="EN//getting_started/walkthrough2/CreateGeometry.rst"> </topic> toc.xml does not reference 'CreatingFeatureType.rst' - add the following: <topic label="CreatingFeatureType" href="EN//getting_started/walkthrough2/CreatingFeatureType.rst"> </topic> toc.xml does not reference 'DeleteFeatureTool.rst' - add the following: <topic label="DeleteFeatureTool" href="EN//getting_started/walkthrough2/DeleteFeatureTool.rst"> </topic> toc.xml does not reference 'EditingGeometrywithWFS.rst' - add the following: <topic label="EditingGeometrywithWFS" href="EN//getting_started/walkthrough2/EditingGeometrywithWFS.rst"> </topic> toc.xml does not reference 'ExportingtoShapefile.rst' - add the following: <topic label="ExportingtoShapefile" href="EN//getting_started/walkthrough2/ExportingtoShapefile.rst"> </topic> toc.xml does not reference 'FillTool.rst' - add the following: <topic label="FillTool" href="EN//getting_started/walkthrough2/FillTool.rst"> </topic> toc.xml does not reference 'HoleCutter.rst' - add the following: <topic label="HoleCutter" href="EN//getting_started/walkthrough2/HoleCutter.rst"> </topic> toc.xml does not reference 'index.rst' - add the following: <topic label="index" href="EN//getting_started/walkthrough2/index.rst"> </topic> toc.xml does not reference 'Introduction.rst' - add the following: <topic label="Introduction" href="EN//getting_started/walkthrough2/Introduction.rst"> </topic> toc.xml does not reference 'Save.rst' - add the following: <topic label="Save" href="EN//getting_started/walkthrough2/Save.rst"> </topic> toc.xml does not reference 'TakeaBreak!.rst' - add the following: <topic label="TakeaBreak!" href="EN//getting_started/walkthrough2/TakeaBreak!.rst"> </topic> toc.xml does not reference 'walkthrough2.rst' - add the following: <topic label="walkthrough2" href="EN//getting_started/walkthrough2/walkthrough2.rst"> </topic> toc.xml does not reference 'WhattoDoNext.rst' - add the following: <topic label="WhattoDoNext" href="EN//getting_started/walkthrough2/WhattoDoNext.rst"> </topic> toc.xml does not reference 'WMSandWFSIntegration.rst' - add the following: <topic label="WMSandWFSIntegration" href="EN//getting_started/walkthrough2/WMSandWFSIntegration.rst"> </topic> toc.xml does not reference 'WorkingwithAttributes.rst' - add the following: <topic label="WorkingwithAttributes" href="EN//getting_started/walkthrough2/WorkingwithAttributes.rst"> </topic> toc.xml does not reference 'index.rst' - add the following: <topic label="index" href="EN//index.rst"> </topic> toc.xml does not reference 'Linking a document.rst' - add the following: <topic label="Linking a document" href="EN//Linking a document.rst"> </topic> toc.xml does not reference 'Setting a hotlink.rst' - add the following: <topic label="Setting a hotlink" href="EN//Setting a hotlink.rst"> </topic> toc.xml does not reference 'Welcome.rst' - add the following: <topic label="Welcome" href="EN//Welcome.rst"> </topic> toc.xml does not reference 'Working with Documents.rst' - add the following: <topic label="Working with Documents" href="EN//Working with Documents.rst"> </topic> toc.xml refers to 7 missing pages <topic label="ArcSDE Preference Page" href="EN/ArcSDE Preference Page.html"> <topic label="WRIS" href="EN/WRIS.html"> <topic label="DB2 Preferences" href="EN/DB2 Preferences.html"> <topic label="Printing Preferences" href="EN/Printing Preferences.html"> <topic label="WMS Preferences" href="EN/WMS Preferences.html"> <topic label="Map Preferences" href="EN/Map Preferences.html"> <topic label="Layer Preferences" href="EN/Layer Preferences.html"> ________________________________ The contents of this email are confidential and may be subject to legal or professional privilege and copyright. No representation is made that this email is free of viruses or other defects. If you have received this communication in error, you may not copy or distribute any part of it or otherwise disclose its contents to anyone. Please advise the sender of your incorrect receipt of this correspondence.
_______________________________________________ User-friendly Desktop Internet GIS (uDig) http://udig.refractions.net http://lists.refractions.net/mailman/listinfo/udig-devel
