1+ for commit access for Sam
2012/9/4 Jody Garnett <[email protected]>: > Thanks Sam; updating and giving it a go. > > Sam with your permission I would like to nominate your for commit access. > Since you have a build box to keep up, and know you way around Tycho, I feel > you could benefit from > commit access - even just to apply an emergency patch in the event the > community stuffs something up. > > Note even with commit access you can still issue pull requests, and ask for > a careful review in the event you are making changes. > > I understand that the uDig community has not seen an example of your Java > coding. > > For reference Sam has submitted a patches to GeoServer and GeoTools here: > - https://github.com/geotools/geotools/pull/5 > - https://github.com/geoserver/geoserver/pull/9 > > -- > Jody Garnett > > On Tuesday, 4 September 2012 at 8:40 PM, Sam Guymer wrote: > > Because the source features don't technically exist (because they are > built entirely by tycho) to get them to output into the repository > they need to be specified in a category.xml file that is contained in > the same feature as the pom with type eclipse-repository. > > That problem is occurring because the product build includes > net.refractions.udig_platform-feature which then attempts to create a > source feature and source plugins for its plugins. This fails due to > net.refractions.udig.libs not being configured to generate a source > plugin and net.refractions.udig.libs.source not being included in a > product only build. I have created a pull request that only generates > the source features when the sdk profile is active: > https://github.com/uDig/udig-platform/pull/137 > > > On Tue, Sep 4, 2012 at 1:28 PM, Jody Garnett <[email protected]> wrote: > > Okay … have a temp fix in place. > > I have added the building of net.refractions.udig.libs-source to the > -Pproduct profile in plugins/pom.xml. > I hope this is a temporary measure; as I expect this will have an effect on > file size. > > Notes / Questions for Sam: > > Do we need a net.refractions.udig-feature/category.xml file? > > We have net.refractions.udig_sdk-feature/category.xml <-- file controls how > features are listed when generating update site > This category.xml file talks about two products as shown below: > > <feature url="features/net.refractions.udig_printing-feature_0.0.0.jar" > id="net.refractions.udig_printing-feature" version="0.0.0"> > <category name="net.refractions.udig"/> > <category name="net.refractions.udig.sdk"/> > </feature> > <feature > url="features/net.refractions.udig_printing-feature.source_0.0.0.jar" > id="net.refractions.udig_printing-feature.source" version="0.0.0"> > <category name="net.refractions.udig.sdk"/> > </feature > > We do not have a net.refractions.udig-feature/category.xml file and I > wondered if this was part of the problem? > > This is a bit of a long shot as a of research shows that the tycho project > is using the category.xml file in "the wrong" fashion to control execution. > Indeed the eclipse "repository" target (which Sam's patch has migrated us > to) is considered the long term solution. > > -- > Jody Garnett > > On Tuesday, 4 September 2012 at 11:13 AM, Jody Garnett wrote: > > Sigh. > > Apparently my review was poor; and a build box Mark set up for me is > reporting a failure. > > Stack trace : > org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute > goal > org.eclipse.tycho.extras:tycho-source-feature-plugin:0.15.0:source-feature > (source-feature) on project net.refractions.udig_platform-feature: Could not > generate source feature for project MavenProject: > net.refractions:net.refractions.udig_platform-feature:1.3.2.qualifier @ > /var/lib/jenkins/jobs/uDig > Platform/workspace/features/net.refractions.udig_platform-feature/pom.xml > Missing sources for plugins > [net.refractions.udig.libs_1.3.2.201209040033] > > I am going to have a look and see what I can do; sorry for the delay :( > -- > Jody Garnett > > On Monday, 3 September 2012 at 11:31 PM, Jody Garnett wrote: > > Sam kicked last weeks SDK to the curb (it did not include source). And > submitted - https://github.com/uDig/udig-platform/pull/136 > > A bit of playing around with version numbers and we have a new SDK available > for testing. > > Thanks Sam! > > -- > Jody Garnett > > > > _______________________________________________ > User-friendly Desktop Internet GIS (uDig) > http://udig.refractions.net > http://lists.refractions.net/mailman/listinfo/udig-devel > _______________________________________________ User-friendly Desktop Internet GIS (uDig) http://udig.refractions.net http://lists.refractions.net/mailman/listinfo/udig-devel
