Thanks Naz I will give that a go; issue reported here: 
https://jira.codehaus.org/browse/UDIG-1943 

Mark handled the code review on this one; looks like I need some more defensive 
coding. Still I am glad the approach is working.


-- 
Jody Garnett


On Wednesday, 12 September 2012 at 9:54 AM, Nazareno Chan wrote:

> Hi Guys,
>  
> Noticed some exceptions when opening the DocumentPropertyPage. I think these 
> were missed as part of its enablement check:
> Non-resource item is selected
> 
> Open Bookmarks view
> Select an item in the view
> Go to Data > Resource Properties
> Exception:
> 
>  
> !ENTRY org.eclipse.ui 4 0 2012-09-12 09:51:15.055
> !MESSAGE Unhandled event loop exception
> !STACK 0
> java.lang.NullPointerException
>         at 
> net.refractions.udig.core.SelectionProviderForwarder.addSelectionChangedListener(SelectionProviderForwarder.java:47)
>         at 
> org.eclipse.ui.actions.SelectionProviderAction.<init>(SelectionProviderAction.java:60)
>         at 
> org.eclipse.ui.dialogs.PropertyDialogAction.<init>(PropertyDialogAction.java:89)
>         at 
> net.refractions.udig.ui.properties.ProperitesCommandHandler.execute(ProperitesCommandHandler.java:55)
>         at 
> org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:293)
>         at 
> org.eclipse.core.commands.Command.executeWithChecks(Command.java:476)
>         at 
> org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:508)
>         at 
> org.eclipse.ui.internal.handlers.HandlerService.executeCommand(HandlerService.java:169)
>         at 
> org.eclipse.ui.internal.handlers.SlaveHandlerService.executeCommand(SlaveHandlerService.java:241)
>         at 
> org.eclipse.ui.menus.CommandContributionItem.handleWidgetSelection(CommandContributionItem.java:829)
>         at 
> org.eclipse.ui.menus.CommandContributionItem.access$19(CommandContributionItem.java:815)
>         at 
> org.eclipse.ui.menus.CommandContributionItem$5.handleEvent(CommandContributionItem.java:805)
>         at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
>         at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1053)
>         at 
> org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4165)
>         at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3754)
>         at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2701)
>         at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2665)
>         at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2499)
>         at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:679)
>         at 
> org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
>         at 
> org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:668)
>         at 
> org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
>         at 
> net.refractions.udig.internal.ui.UDIGApplication.start(UDIGApplication.java:138)
>         at 
> org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
>         at 
> org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
>         at 
> org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
>         at 
> org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:344)
>         at 
> org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>         at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>         at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>         at java.lang.reflect.Method.invoke(Method.java:597)
>         at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:622)
>         at org.eclipse.equinox.launcher.Main.basicRun(Main.java:577)
>         at org.eclipse.equinox.launcher.Main.run(Main.java:1410)
>         at org.eclipse.equinox.launcher.Main.main(Main.java:1386)
>  
>  
> Tool is selected
> 
> Select Feature Selection tool
> Go to Data > Resource
> Exception:
> 
>  
> !ENTRY org.eclipse.ui 4 0 2012-09-12 09:53:20.823
> !MESSAGE Unhandled event loop exception
> !STACK 0
> java.lang.NullPointerException
>         at 
> net.refractions.udig.ui.properties.ProperitesCommandHandler.execute(ProperitesCommandHandler.java:57)
>         at 
> org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:293)
>         at 
> org.eclipse.core.commands.Command.executeWithChecks(Command.java:476)
>         at 
> org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:508)
>         at 
> org.eclipse.ui.internal.handlers.HandlerService.executeCommand(HandlerService.java:169)
>         at 
> org.eclipse.ui.internal.handlers.SlaveHandlerService.executeCommand(SlaveHandlerService.java:241)
>         at 
> org.eclipse.ui.menus.CommandContributionItem.handleWidgetSelection(CommandContributionItem.java:829)
>         at 
> org.eclipse.ui.menus.CommandContributionItem.access$19(CommandContributionItem.java:815)
>         at 
> org.eclipse.ui.menus.CommandContributionItem$5.handleEvent(CommandContributionItem.java:805)
>         at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
>         at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1053)
>         at 
> org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4165)
>         at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3754)
>         at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2701)
>         at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2665)
>         at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2499)
>         at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:679)
>         at 
> org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
>         at 
> org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:668)
>         at 
> org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
>         at 
> net.refractions.udig.internal.ui.UDIGApplication.start(UDIGApplication.java:138)
>         at 
> org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
>         at 
> org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
>         at 
> org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
>         at 
> org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:344)
>         at 
> org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>         at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>         at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>         at java.lang.reflect.Method.invoke(Method.java:597)
>         at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:622)
>         at org.eclipse.equinox.launcher.Main.basicRun(Main.java:577)
>         at org.eclipse.equinox.launcher.Main.run(Main.java:1410)
>         at org.eclipse.equinox.launcher.Main.main(Main.java:1386)
>  
> Thanks,
> Naz Chan
>  
> 
>   ________________________________   
> The contents of this email are confidential and may be subject to legal or 
> professional privilege and copyright. No representation is made that this 
> email is free of viruses or other defects. If you have received this 
> communication in error, you may not copy or distribute any part of it or 
> otherwise disclose its contents to anyone. Please advise the sender of your 
> incorrect receipt of this correspondence.
> _______________________________________________
> User-friendly Desktop Internet GIS (uDig)
> http://udig.refractions.net
> http://lists.refractions.net/mailman/listinfo/udig-devel
> 
> 


_______________________________________________
User-friendly Desktop Internet GIS (uDig)
http://udig.refractions.net
http://lists.refractions.net/mailman/listinfo/udig-devel

Reply via email to