Hi Andrea, Thanks alot for the review mate! I'll check our project sched here and try to get back on the comments asap. :)
Naz Chan > -----Original Message----- > From: [email protected] [mailto:udig-devel- > [email protected]] On Behalf Of andrea antonello > Sent: Wednesday, 19 September 2012 6:16 PM > To: ML udig > Subject: Re: [udig-devel] document view - review > > And last one. Checked headers and findbugs. > I just saw one or two headers missing, but that can also be fixed after > the merging of the pull request. Findbugs doesn't complain. > > Going to do the pull, > Cheers, > Andrea > > > > On Wed, Sep 19, 2012 at 9:58 AM, andrea antonello > <[email protected]> wrote: > > Let me quickly add one more: > > > > - if I drag (like to do a bbox) with the feature selection tool, very > > strange things happen > > > > On Wed, Sep 19, 2012 at 9:56 AM, andrea antonello > > <[email protected]> wrote: > >> Hi Naz, I just finished the first part of the review. > >> > >> Comments: > >> - when I change layer I get a NPE when entering the Resource Page. > >> This looks to be this here: UDIG-1943 Just reminding of it > >> - the selection can be done only with the feature selection tool. I > >> use the bbox selection tool 99% of my time in udig as I see most of > >> the users. Is there a possibility to use that one? Or does that hit > >> performance/other issues? > >> - while the file opens, the wikipedia links of the test dataset > >> doesn't open for me. I configured them as: type: web, action:open > >> - when selecting with the selection tool I get geotools warnings... > >> not so nice, not sure if they are connected to the properties file, > >> as far as I know they also have one: > >> Sep 19, 2012 9:32:51 AM org.geotools.gce.imagemosaic.Utils > >> loadMosaicProperties > >> INFO: Required key Levels not found. > >> - I think this one is strategic: the configuration of the doc view > >> should be persisted, so that it survives a catalog remove/readd. I > >> see that a properties file is created, which stores the config (not > >> the hotlink thought), but when I remove from catalog and readd, the > >> doc view forgets the config. That one is bad if you have quite some > >> stuff in there. And it would also get portable. > >> > >> Apart of that I love the docs view already and am wondering how I > >> could live without, so keep the good stuff going :) > >> > >> Cheers, > >> Andrea > _______________________________________________ > User-friendly Desktop Internet GIS (uDig) http://udig.refractions.net > http://lists.refractions.net/mailman/listinfo/udig-devel The contents of this email are confidential and may be subject to legal or professional privilege and copyright. No representation is made that this email is free of viruses or other defects. If you have received this communication in error, you may not copy or distribute any part of it or otherwise disclose its contents to anyone. Please advise the sender of your incorrect receipt of this correspondence. _______________________________________________ User-friendly Desktop Internet GIS (uDig) http://udig.refractions.net http://lists.refractions.net/mailman/listinfo/udig-devel
