Okay managed to fix this … by changing the sed expression to strip of the extra
space.
Ended up with
PLUGIN_NAME=$(grep "Bundle-SymbolicName" ${MANIFEST} | sed -e "s/;.*//" -e
"s/^.*:\ \s*//")
PLUGIN_VERSION=$(grep "Bundle-Version" ${MANIFEST} | sed -e "s/\.qualifier.*//"
-e "s/^.*:\ \s*//")
While I am sure \s* was supposed to match white space? Adding a \ \s* did the
trick for me :(
I will update an SDK with today's corrections shortly.
--
Jody Garnett
On Thursday, 4 October 2012 at 10:43 PM, Jody Garnett wrote:
> Okay back to the first problem (sorry for these crazy emails I am not very
> good at this part).
> > -The plugins that need unpacking are not unpacked:
> > com.cvsreader, com.lowagie.itext, net.refractions.udig.libs.db2,
> > net.refractions.udig.libs.oracle, net.refractions.udig.libs,
> > org.apache.log4j
> >
> >
> >
> >
>
> This issue is still present when I perform a build. The code is:
>
> 56 MANIFESTS=$(grep -irl "Eclipse-BundleShape: dir" --include
> "MANIFEST.MF" --exclude-dir "src" --exclude-dir "bin" --exclude-dir "target"
> --exclude-dir "lib*" ../plugins)
> 57 for MANIFEST in ${MANIFESTS}; do
> 58 PLUGIN_NAME=$(grep "Bundle-SymbolicName" ${MANIFEST} | sed -e
> "s/;.*//" -e "s/^.*:\s*//")
> 59 PLUGIN_VERSION=$(grep "Bundle-Version" ${MANIFEST} | sed -e
> "s/\.qualifier.*//" -e "s/^.*:\s*//")
> 60
> echo Plugin:${PLUGIN_NAME}
> echo Version:${PLUGIN_VERSION}
> echo
> "${BUILD_SDK}"/plugins/${PLUGIN_NAME}_${PLUGIN_VERSION}*.jar
> 61
> 62 for FILE in
> "${BUILD_SDK}"/plugins/${PLUGIN_NAME}_${PLUGIN_VERSION}*.jar
> 63 do
> 64 BASENAME=$(basename "${FILE}" .jar)
> 65 if [ ! -d "${BASENAME}" ]; then
> 66 unzip -d "${BUILD_SDK}/plugins/${BASENAME}" "${FILE}"
> && rm "${FILE}"
> 67 fi
> 68 done
> 69 done
>
>
> > If you are able to do some debugging:
> > Line 56 in sdk.sh (http://sdk.sh) finds the manifest files of the plugins
> > that need unpacking.
> > You can run this in a shell to see if it produces a list with the plugins
> > above
> >
>
> This correctly generates the following list:
>
> grep -irl "Eclipse-BundleShape: dir" --include "MANIFEST.MF" --exclude-dir
> "src" --exclude-dir "bin" --exclude-dir "target" --exclude-dir "lib*"
> ../plugins
> ../plugins/com.csvreader/META-INF/MANIFEST.MF
> ../plugins/com.lowagie.itext/META-INF/MANIFEST.MF
> ../plugins/eu.udig.catalog.csw/META-INF/MANIFEST.MF
> ../plugins/net.refractions.udig.libs/META-INF/MANIFEST.MF
> ../plugins/net.refractions.udig.libs.db2/META-INF/MANIFEST.MF
> ../plugins/net.refractions.udig.libs.oracle/META-INF/MANIFEST.MF
> ../plugins/net.refractions.udig.ui.tests/META-INF/MANIFEST.MF
> ../plugins/org.apache.log4j/META-INF/MANIFEST.MF
>
> Trying out the next several lines by hand:
>
> > export MANIFEST=../plugins/com.csvreader/META-INF/MANIFEST.MF
> > grep "Bundle-SymbolicName" ${MANIFEST} | sed -e "s/;.*//" -e "s/^.*:\s*//"
> com.cvsreader
>
> > grep "Bundle-Version" ${MANIFEST} | sed -e "s/\.qualifier.*//" -e
> > "s/^.*:\s*//"
> 2.0
>
> Q: There is a leading space in front of com.csvreader and 2.0 - is that going
> to be a problem when forming the filename on line 62?
>
> A: Apparently so given the following logs
>
> Plugin: com.cvsreader
> Version: 2.0
> ./build/sdk/udig_sdk/plugins/ com.cvsreader_
> unzip: cannot find or open ./build/sdk/udig_sdk/plugins/,
> ./build/sdk/udig_sdk/plugins/.zip or ./build/sdk/udig_sdk/plugins/.ZIP.
> unzip: cannot find or open com.cvsreader_, com.cvsreader_.zip or
> com.cvsreader_.ZIP.
> Plugin: com.lowagie.itext
> Version: 2.1.7
> ./build/sdk/udig_sdk/plugins/ com.lowagie.itext_
> unzip: cannot find or open ./build/sdk/udig_sdk/plugins/,
> ./build/sdk/udig_sdk/plugins/.zip or ./build/sdk/udig_sdk/plugins/.ZIP.
> unzip: cannot find or open com.lowagie.itext_, com.lowagie.itext_.zip or
> com.lowagie.itext_.ZIP.
> Plugin: eu.udig.catalog.csw
> Version: 1.0.0
> ./build/sdk/udig_sdk/plugins/ eu.udig.catalog.csw_
> unzip: cannot find or open ./build/sdk/udig_sdk/plugins/,
> ./build/sdk/udig_sdk/plugins/.zip or ./build/sdk/udig_sdk/plugins/.ZIP.
> unzip: cannot find or open eu.udig.catalog.csw_, eu.udig.catalog.csw_.zip or
> eu.udig.catalog.csw_.ZIP.
> Plugin: net.refractions.udig.libs
> Version: 1.3.3
> ./build/sdk/udig_sdk/plugins/ net.refractions.udig.libs_
> unzip: cannot find or open ./build/sdk/udig_sdk/plugins/,
> ./build/sdk/udig_sdk/plugins/.zip or ./build/sdk/udig_sdk/plugins/.ZIP.
> unzip: cannot find or open net.refractions.udig.libs_,
> net.refractions.udig.libs_.zip or net.refractions.udig.libs_.ZIP.
> Plugin: net.refractions.udig.libs.db2
> Version: 1.2.0
> ./build/sdk/udig_sdk/plugins/ net.refractions.udig.libs.db2_
> unzip: cannot find or open ./build/sdk/udig_sdk/plugins/,
> ./build/sdk/udig_sdk/plugins/.zip or ./build/sdk/udig_sdk/plugins/.ZIP.
> unzip: cannot find or open net.refractions.udig.libs.db2_,
> net.refractions.udig.libs.db2_.zip or net.refractions.udig.libs.db2_.ZIP.
> Plugin: net.refractions.udig.libs.oracle
> Version: 1.2.0
> ./build/sdk/udig_sdk/plugins/ net.refractions.udig.libs.oracle_
> unzip: cannot find or open ./build/sdk/udig_sdk/plugins/,
> ./build/sdk/udig_sdk/plugins/.zip or ./build/sdk/udig_sdk/plugins/.ZIP.
> unzip: cannot find or open net.refractions.udig.libs.oracle_,
> net.refractions.udig.libs.oracle_.zip or
> net.refractions.udig.libs.oracle_.ZIP.
> Plugin: net.refractions.udig.ui.tests
> Version: 1.2.0
> ./build/sdk/udig_sdk/plugins/ net.refractions.udig.ui.tests_
> unzip: cannot find or open ./build/sdk/udig_sdk/plugins/,
> ./build/sdk/udig_sdk/plugins/.zip or ./build/sdk/udig_sdk/plugins/.ZIP.
> unzip: cannot find or open net.refractions.udig.ui.tests_,
> net.refractions.udig.ui.tests_.zip or net.refractions.udig.ui.tests_.ZIP.
> Plugin: org.apache.log4j
> Version: 1.2.12
> ./build/sdk/udig_sdk/plugins/ org.apache.log4j_
> unzip: cannot find or open ./build/sdk/udig_sdk/plugins/,
> ./build/sdk/udig_sdk/plugins/.zip or ./build/sdk/udig_sdk/plugins/.ZIP.
> unzip: cannot find or open org.apache.log4j_, org.apache.log4j_.zip or
> org.apache.log4j_.ZIP.
>
>
>
_______________________________________________
User-friendly Desktop Internet GIS (uDig)
http://udig.refractions.net
http://lists.refractions.net/mailman/listinfo/udig-devel
