On Mon, Jul 20, 2009 at 03:28:06PM +0100, Martin Ling wrote: > On Sun, Jul 19, 2009 at 01:00:03PM +0200, Frank van Maarseveen wrote: > > > > The patch below has been tested and it seems to behave well. Occasionally > > there are rendering artefacts in the preview image (e.g. at crop area > > boundaries). I've seen similar issues in rendering before and the rotate > > control operates at a higher level so I think it's unrelated. > > Works well for me too. One change I might suggest is to keep the values > displayed in the rotation control normalized to -180 < a <= 180. The > attached patch applied on top of yours will do this.
Thanks, Regarding the 180 degree patch: I'd write data->unnormalized_angle = fmod(data->unnormalized_angle, 360.0); instead of data->unnormalized_angle -= (360.0 * trunc(data->unnormalized_angle / 360.0)); and I'm a bit concerned about gtk_adjustment_set_value() call which will probably call adjustment_update_rotation() back again at least once because of a new "value-changed" signal. It has the potential of causing endless recursion. The tests <= -180 and > 180 should protect us but the numbers involved might just not be representable in a double so in theory there could be a very small error causing an oscillation with infinite recursion as result. I just don't know, I'm not a GTK expert but to me this looks a bit fragile. Can't trigger any problems though. -- Frank ------------------------------------------------------------------------------ Enter the BlackBerry Developer Challenge This is your chance to win up to $100,000 in prizes! For a limited time, vendors submitting new applications to BlackBerry App World(TM) will have the opportunity to enter the BlackBerry Developer Challenge. See full prize details at: http://p.sf.net/sfu/Challenge _______________________________________________ ufraw-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ufraw-devel
