Thilo Goetz wrote:
Changes look ok, but I'm wondering: we now have CAS, CommonCas,
AbstractCas and AbstractCas_ImplBase, all in org.apache.uima.cas. Why
is AbstractCas_ImplBase in the interfaces package? Can we please move
it to the appropriate impl package? Any chance we can consolidate
AbstractCas and CommonCas?
I was taking the refactoring a step at a time, and re-running tests
along the way :-)
The AbstractCas has common things for all CAS impls related to
management of the CAS.
The CommonCas is a factoring out of common things between 2 specific
impls / interfaces to the CAS.
Another round of refactoring might now be reasonable to consider which
of the methods/etc. in the CommonCas would be appropriate for all CAS
impls (Plain CAS, JCas, and unspecified future CAS interfaces).
-Marshall
- Re: [jira] Resolved: (UIMA-143) JCas and CAS interface and ... Marshall Schor
-
