Thilo Goetz wrote: > Marshall Schor wrote: > >> Thilo Goetz wrote: >> >>> Marshall Schor wrote: >>> >>> >>>> Thilo Goetz wrote: >>>> >>>> >>>>> It's probably not important, but I don't understand what the >>>>> difference is between "creating a top level pearSpecifier kind >>>>> of AE" (your words) and "create AEs ... from top-level pear >>>>> descriptors" (my words). >>>>> >>>>> >>>>> >>>> Hmmm, if we're doing the same thing, then it should have been failing >>>> for your situations. Do you have a sample / test case or whatever I >>>> could try? I'll back out the change and test why it *isn't* failing. >>>> That should shed some light on my understanding in this area :-) >>>> >>>> >>> How about the whitespace tokenizer and the regex annotator from the >>> sandbox, they come pre-packaged as pears and you can run them directly, >>> they have no dependencies. >>> >>> >> How do you do this? Is there a test case somewhere that does this? I >> think if these are PEARs, you would have to first "install" the pear >> somewhere, and then extract the pear specifier and run it inside a >> simple application driver that doesn't wrap it in another aggregate, for >> instance. >> > > The easiest thing to do is to run the pear installer on a pear > (org.apache.uima.tools.pear.install.InstallPear from tools), and > then click the "run your pear in CVD" or whatever it's called button. > Set a break point in org.apache.uima.tools.cvd.MainFrame.setupAE(File). > The CVD loads the top-level pear descriptor directly, without any > embedding. >
Thanks Thilo - I did this and confirmed the error occurs as expected without the new fix. I then looked at why we didn't see it before - and found out that it is because the whole method of handling the outside environment was changed to rely on the passed-in "additionalParameters", in http://issues.apache.org/jira/browse/UIMA-1107, last November. While investigating that I was mislead to Jira UIMA-1170 due to a type that reversed these last 2 digits... fixed that too in the SVN commit message. Unfortunately, the Jira system hasn't picked up the change in the SVN property that re-associated that fix from UIMA-1170 to UIMA-1107 - If it doesn't pick it up after a day, I'll put in a comment about this in both Jira issues, unless someone knows how to tweak the Jira system to update this. -Marshall >> If you run this in the DocumentAnalyzer - it embeds it inside a CPE, not >> a s a top level descriptor. >> > > Could hat be the reason for http://issues.apache.org/jira/browse/UIMA-1113? > But then there's also http://issues.apache.org/jira/browse/UIMA-1114. > I never use the DocumentAnalyzer myself, so I didn't investigate any > further. > > >> If you don't have a test case already, I'll drum up one using the >> PearRuntimeTest as a template. (That test embeds the pearSpecifiier in >> an aggregate, so would need to change). >> >> -Marshall >> >>> I did run some regression tests after your changes (with proprietary >>> pear files) and everything has worked so far. >>> >>> --Thilo >>> >>> >>> >>>> -Marshall >>>> >>>> >>>>> Marshall Schor wrote: >>>>> >>>>> >>>>> >>>>>> The thing that was failing was creating a top level pearSpecifier kind >>>>>> of AE... regular AE's worked just fine ;-) . >>>>>> >>>>>> -Marshall >>>>>> >>>>>> Thilo Goetz (JIRA) wrote: >>>>>> >>>>>> >>>>>> >>>>>>> [ >>>>>>> https://issues.apache.org/jira/browse/UIMA-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12736669#action_12736669 >>>>>>> ] >>>>>>> >>>>>>> Thilo Goetz commented on UIMA-1465: >>>>>>> ----------------------------------- >>>>>>> >>>>>>> I create AEs like that all the time, from top-level pear descriptors. >>>>>>> It's what the CVD does, for example (unless the datapath is set). This >>>>>>> most definitely used to work. >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>>> running a pearSpecifier as a top level component fails with >>>>>>>> NullPointerException >>>>>>>> -------------------------------------------------------------------------------- >>>>>>>> >>>>>>>> Key: UIMA-1465 >>>>>>>> URL: https://issues.apache.org/jira/browse/UIMA-1465 >>>>>>>> Project: UIMA >>>>>>>> Issue Type: Bug >>>>>>>> Components: Core Java Framework >>>>>>>> Affects Versions: 2.2.2 >>>>>>>> Reporter: Marshall Schor >>>>>>>> Assignee: Marshall Schor >>>>>>>> Fix For: 2.3 >>>>>>>> >>>>>>>> >>>>>>>> This happens when produceAnalysisEngine call is done with no >>>>>>>> additional parameters, for top level pears. Our previous testing has >>>>>>>> always had the pear contained in an aggregrate wrapper, which I think >>>>>>>> works. >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>> >>>>> >>>>> >>> >>> > > > >
