[ 
https://issues.apache.org/jira/browse/UIMA-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12852309#action_12852309
 ] 

Tommaso Teofili commented on UIMA-1747:
---------------------------------------

Hi Greg, it seems to me you're right in regards of the Type string so the patch 
should be fixing the issue.

I am wondering about the need of the line:
Type markupType = 
cas.getTypeSystem().getType("org.apache.uima.tika.MarkupAnnotation")
since it seems it is never used, so we may choose to remove it.

In regards of Exception now that the package name is fixed, it's something it 
should happen only when that FS is not defined inside the TypeSystem.
So for example we may choose to create an UnknownTypeException like the one 
inside the ConceptMapper
https://svn.apache.org/repos/asf/incubator/uima/sandbox/trunk/ConceptMapper/src/main/java/org/apache/uima/conceptMapper/support/tokens/UnknownTypeException.java
but extending RuntimeException so that we should not change method signature to 
declare throwing exception.
What do you think?

> TikaAnnotator: null pointer exception in MarkupHandler.populateCAS
> ------------------------------------------------------------------
>
>                 Key: UIMA-1747
>                 URL: https://issues.apache.org/jira/browse/UIMA-1747
>             Project: UIMA
>          Issue Type: Bug
>          Components: Sandbox-TikaAnnotator
>    Affects Versions: 2.3
>            Reporter: Greg Holmberg
>            Priority: Blocker
>         Attachments: UIMA-1747-patch.txt
>
>
> I get the following NPE.
> java.lang.NullPointerException
>       at org.apache.uima.cas.impl.CASImpl.createFS(CASImpl.java:474)
>       at 
> org.apache.uima.tika.MarkupHandler.populateCAS(MarkupHandler.java:168)
>       at 
> org.apache.uima.tika.TIKAWrapper.populateCASfromURL(TIKAWrapper.java:105)
>       at 
> org.apache.uima.tika.FileSystemCollectionReader.getNext(FileSystemCollectionReader.java:99)
>       at 
> org.apache.uima.collection.impl.cpm.engine.ArtifactProducer.readNext(ArtifactProducer.java:494)
>       at 
> org.apache.uima.collection.impl.cpm.engine.ArtifactProducer.run(ArtifactProducer.java:711)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to