Hi all. We're implementing client certificate authentication with nginx and unicorn.
Nginx configured in the following way: proxy_set_header X-SSL-Client-Cert $ssl_client_cert; When client submits certificate and nginx passes it to the unicorn, unicorn responds with 400 (Bad Request). This caused because nginx doesn't use "\r\n" they using just "\n" and multilne headers is failed to parse (I've added test). Accorording to RFC2616 section 19.3: https://www.w3.org/Protocols/rfc2616/rfc2616-sec19.html#sec19.3 "The line terminator for message-header fields is the sequence CRLF. However, we recommend that applications, when parsing such headers, recognize a single LF as a line terminator and ignore the leading CR." CRLF changed to ("\r\n" | "\n") Github commit https://github.com/uno4ki/unicorn/commit/ed127b66e162aaf1 76de05720f6be758f8b41b1f PS: Googling "nginx unicorn ssl_client_cert" shows the problem. --- ext/unicorn_http/unicorn_http_common.rl | 2 +- test/unit/test_http_parser.rb | 16 ++++++++++++++++ 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/ext/unicorn_http/unicorn_http_common.rl b/ext/unicorn_http/unicorn_http_common.rl index cc1d455..507e570 100644 --- a/ext/unicorn_http/unicorn_http_common.rl +++ b/ext/unicorn_http/unicorn_http_common.rl @@ -4,7 +4,7 @@ #### HTTP PROTOCOL GRAMMAR # line endings - CRLF = "\r\n"; + CRLF = ("\r\n" | "\n"); # character types CTL = (cntrl | 127); diff --git a/test/unit/test_http_parser.rb b/test/unit/test_http_parser.rb index c72f7f2..4b1a16e 100644 --- a/test/unit/test_http_parser.rb +++ b/test/unit/test_http_parser.rb @@ -230,6 +230,22 @@ def test_nasty_pound_header assert_equal expect, req['HTTP_X_SSL_BULLSHIT'] end + def test_multiline_header_0d0a + parser = HttpParser.new + parser.buf << "GET / HTTP/1.0\r\nX-Multiline-Header: foo bar\r\n\tcha cha\r\n\tzha zha\r\n\r\n" + req = parser.env + assert_equal req, parser.parse + assert_equal 'foo bar cha cha zha zha', req['HTTP_X_MULTILINE_HEADER'] + end + + def test_multiline_header_0a + parser = HttpParser.new + parser.buf << "GET / HTTP/1.0\nX-Multiline-Header: foo bar\n\tcha cha\n\tzha zha\n\n" + req = parser.env + assert_equal req, parser.parse + assert_equal 'foo bar cha cha zha zha', req['HTTP_X_MULTILINE_HEADER'] + end + def test_continuation_eats_leading_spaces parser = HttpParser.new header = "GET / HTTP/1.1\r\n" \ -- 2.10.1 -- unsubscribe: unicorn-public+unsubscr...@bogomips.org archive: https://bogomips.org/unicorn-public/
