Xuanzhong Wei <azr...@gmail.com> wrote:
> diff --git a/ext/unicorn_http/unicorn_http.rl
> b/ext/unicorn_http/unicorn_http.rl
> index 6fc3498..357440b 100644
> --- a/ext/unicorn_http/unicorn_http.rl
> +++ b/ext/unicorn_http/unicorn_http.rl
> @@ -921,6 +921,7 @@ void Init_unicorn_http(void)
> VALUE mUnicorn, cHttpParser;
>
> mark_ary = rb_ary_new();
> + rb_global_variable(&mark_ary);
> mUnicorn = rb_define_module("Unicorn");
> cHttpParser = rb_define_class_under(mUnicorn, "HttpParser", rb_cObject);
> eHttpParserError =
> @@ -976,7 +977,6 @@ void Init_unicorn_http(void)
> init_unicorn_httpdate(mark_ary);
>
> OBJ_FREEZE(mark_ary);
> - rb_global_variable(&mark_ary);
Yes, the compiler should be free to drop mark_ary by here, since
it only needs its address (not the actual VALUE) and OBJ_FREEZE
only accesses the RBasic->flags field if init_unicorn_httpdate
gets inlined.
Pushed to master as e85de00a3065461f6fac466276d915b809f40c7c.
Also, created a 5.3-stable branch for 5.3.1 (to be released today)
@ git://bogomips.org/unicorn
--
unsubscribe: unicorn-public+unsubscr...@bogomips.org
archive: https://bogomips.org/unicorn-public/
