fs/unionfs/copyup.c | 2 +-
fs/unionfs/mmap.c | 86 ++++++++++++++++-----------------------------------
2 files changed, 28 insertions(+), 60 deletions(-)
New commits:
commit 55810f4fd325f723566376e724eb1434e7d24eb7
Author: Erez_Zadok <[EMAIL PROTECTED]>
Date: Sat Jul 14 03:36:15 2007 -0400
Unionfs: rewrite do_unionfs_readpage to use vfs_read (bugfix)
In do_unionfs_readpage, we used to call the lower file system's ->readpage.
However, some file systems (e.g., tmpfs) don't implement ->readpage, causing
a NULL pointer dereference under certain conditions, especially under severe
memory pressure. This patch reimplements do_unionfs_readpage using
vfs_read, which makes the code simpler and more reliable, as we depend on
the VFS to do most of the hard work (even if this implementation might be a
bit slower).
This fix also makes sense because it makes the mmap code in unionfs more
symmetric with unionfs_commit_write --- which uses vfs_write().
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
commit c13b39c0714161fdfb04373a2d0ed9c9402bc6a5
Author: Erez_Zadok <[EMAIL PROTECTED]>
Date: Sat Jul 14 03:25:02 2007 -0400
Unionfs: bugfix -- set copied up open file mode to read and write
When we copyup a file, we used to set the new file's open mode to write
only. But we need read permission too. We need write permission because
we're creating a new file; and we need read permission because the original
file had to have been readable. If we don't set the new files permission to
BOTH read and write, we get -EBADF when trying calling vfs_read/vfs_write on
a copied up file. (This fix is somewhat related to unionfs_readpage fixes
that use vfs_read instead of calling the lower readpage.)
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
_______________________________________________
unionfs-cvs mailing list: http://unionfs.filesystems.org/
[email protected]
http://www.fsl.cs.sunysb.edu/mailman/listinfo/unionfs-cvs
