commit f4780fee417d33b1197badb8985bb89a88eea671
Author: Erez Zadok <[EMAIL PROTECTED]>
Date: Tue Dec 25 17:01:40 2007 -0500
Unionfs: remove unnecessary locking in follow-link
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
diff --git a/fs/unionfs/inode.c b/fs/unionfs/inode.c
index 8083d13..44fc2fc 100644
--- a/fs/unionfs/inode.c
+++ b/fs/unionfs/inode.c
@@ -842,7 +842,8 @@ out:
* nor do we need to revalidate it either. It is safe to not lock our
* dentry here, nor revalidate it, because unionfs_follow_link does not do
* anything (prior to calling ->readlink) which could become inconsistent
- * due to branch management.
+ * due to branch management. We also don't need to lock our super because
+ * this function isn't affected by branch-management.
*/
static void *unionfs_follow_link(struct dentry *dentry, struct nameidata *nd)
{
@@ -850,8 +851,6 @@ static void *unionfs_follow_link(struct dentry *dentry,
struct nameidata *nd)
int len = PAGE_SIZE, err;
mm_segment_t old_fs;
- unionfs_read_lock(dentry->d_sb);
-
/* This is freed by the put_link method assuming a successful call. */
buf = kmalloc(len, GFP_KERNEL);
if (unlikely(!buf)) {
@@ -875,7 +874,6 @@ static void *unionfs_follow_link(struct dentry *dentry,
struct nameidata *nd)
out:
unionfs_check_dentry(dentry);
- unionfs_read_unlock(dentry->d_sb);
return ERR_PTR(err);
}
_______________________________________________
unionfs-cvs mailing list: http://unionfs.filesystems.org/
[email protected]
http://www.fsl.cs.sunysb.edu/mailman/listinfo/unionfs-cvs
