Documentation/filesystems/unionfs/concepts.txt | 20 +-
Documentation/filesystems/unionfs/issues.txt | 12 +-
Documentation/filesystems/unionfs/usage.txt | 43 ++-
fs/drop_caches.c | 4 +-
fs/stack.c | 6 +
fs/unionfs/Makefile | 2 +-
fs/unionfs/commonfops.c | 22 +-
fs/unionfs/copyup.c | 16 +-
fs/unionfs/dentry.c | 110 +++--
fs/unionfs/dirfops.c | 4 +-
fs/unionfs/dirhelper.c | 11 +-
fs/unionfs/fanout.h | 14 +-
fs/unionfs/file.c | 53 +--
fs/unionfs/inode.c | 580 ++++++++++++------------
fs/unionfs/lookup.c | 20 +-
fs/unionfs/main.c | 19 +-
fs/unionfs/mmap.c | 33 +-
fs/unionfs/rename.c | 114 +++---
fs/unionfs/subr.c | 4 +-
fs/unionfs/super.c | 65 ++--
fs/unionfs/union.h | 39 +-
fs/unionfs/unlink.c | 31 +-
fs/unionfs/xattr.c | 16 +-
include/linux/mm.h | 1 -
24 files changed, 656 insertions(+), 583 deletions(-)
New commits:
commit 882ba024c0924672eb5ef1889a8255aaccdb4aaa
Author: Erez Zadok <[EMAIL PROTECTED]>
Date: Fri Dec 28 13:32:04 2007 -0500
Unionfs: release 2.2
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
commit a638e85d8053979e5f351d3bf429115ff98e4a32
Author: Erez Zadok <[EMAIL PROTECTED]>
Date: Fri Dec 28 10:42:42 2007 -0500
Unionfs: don't check parent dentries
Parent dentries may not be locked and may change, so don't check them. But
do check parent inodes if they are passed to the method. Also, ensure the
checks are done only if no error occurred.
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
commit 4a87ab64de3ad4bb7932ee25a65f0b714d01bc59
Author: Erez Zadok <[EMAIL PROTECTED]>
Date: Thu Dec 27 19:14:50 2007 -0500
Unionfs: implement d_iput method
This is needed to drop lower objects early enough, under certain conditions,
so the lower objects don't stay behind until umount(). [LTP testing]
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
commit e39e17277e4e3f20f92a390e8da5576cbe47a707
Author: Erez Zadok <[EMAIL PROTECTED]>
Date: Thu Dec 27 19:22:48 2007 -0500
Unionfs: don't check dentry on error
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
commit 1b14dd7771b3ee114171045be6e7882b2331c208
Author: Erez Zadok <[EMAIL PROTECTED]>
Date: Thu Dec 27 19:17:09 2007 -0500
Unionfs: cleanup lower inodes after successful unlink
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
commit c84344ab2500002116842a9bfcff3751e6f308c1
Author: Erez Zadok <[EMAIL PROTECTED]>
Date: Tue Dec 25 17:05:33 2007 -0500
Unionfs: initialize namelist variable in rename
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
commit 60d07f50d2570277e6c7b48d3c252c5a6d20ccc4
Author: Erez Zadok <[EMAIL PROTECTED]>
Date: Tue Dec 25 17:05:33 2007 -0500
Unionfs: minor cleanup in check_empty
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
commit 9a8a36471116c27c3afc798315be49ef856f50cb
Author: Erez Zadok <[EMAIL PROTECTED]>
Date: Tue Dec 25 17:05:33 2007 -0500
Unionfs: update inode times after a successful open
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
commit 9341e7400fcac25b9e7b49b0b5fa9ad2c18ac123
Author: Erez Zadok <[EMAIL PROTECTED]>
Date: Tue Dec 25 17:05:33 2007 -0500
Unionfs: set our superblock a/m/ctime granularity
Set it to 1 ns, because we could be stacked on top of file systems with such
granularity.
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
commit 8d80ec41deef0f034998819a9187f26f4519a94e
Author: Erez Zadok <[EMAIL PROTECTED]>
Date: Fri Dec 28 13:46:23 2007 -0500
Unionfs: handle on lower inodes in lookup
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
commit a51788cbde8f536ecec58af843132830152b1191
Author: Erez Zadok <[EMAIL PROTECTED]>
Date: Tue Dec 25 17:05:33 2007 -0500
Unionfs: minor code rearrangement in rename
To avoid too much code nesting.
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
commit 2b5fde47d177480834ba3034a6437acd61ae1326
Author: Erez Zadok <[EMAIL PROTECTED]>
Date: Fri Dec 28 13:38:19 2007 -0500
Unionfs: implement lockdep classes
Lockdep fixes. Support locking order/classes (e.g., parent -> child ->
whiteout). Remove locking from create_parents: it's enough to just dget the
dentries in question. Move parent locking to from lookup_backend to caller,
unionfs_lookup.
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
commit 6eb2df2f72dc1f02f39a83868d31b6749e216466
Author: Erez Zadok <[EMAIL PROTECTED]>
Date: Thu Dec 27 13:43:32 2007 -0500
Unionfs: prevent false lockdep warnings in stacking
A stackable file system like unionfs often performs an operation on a lower
file system, by calling a vfs_* method, having been called possibly by the
very same method from the VFS. Both calls to the vfs_* method grab a lock
in the same lock class, and hence lockdep complains. This warning is a
false positive in instances where unionfs only calls the vfs_* method on
lower objects; there's a strict lock ordering here: upper objects first,
then lower objects.
We want to prevent these false positives so that lockdep will not shutdown
so it'd still be able to warn us about potentially true locking problems.
So, we temporarily turn off lockdep ONLY AROUND the calls to vfs methods to
which we pass lower objects, and only for those instances where lockdep
complained. While this solution may seem unclean, it is not without
precedent: other places in the kernel also do similar temporary disabling,
of course after carefully having checked that it is the right thing to do.
In the long run, lockdep needs to be taught how to handle about stacking.
Then this patch can be removed. It is likely that such lockdep-stacking
support will do essentially the same as this patch: consider the same
ordering (upper then lower) and consider upper vs. lower locks to be in
different classes.
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
commit 352dca1d44b671966f2fa0e20bf4bfa57e37a53a
Author: Erez Zadok <[EMAIL PROTECTED]>
Date: Tue Dec 25 17:05:33 2007 -0500
Unionfs: remove unnecessary parent lock in create
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
commit 5f25f420cd88fda126689002c3099aca3326c729
Author: Erez Zadok <[EMAIL PROTECTED]>
Date: Tue Dec 25 17:05:33 2007 -0500
Unionfs: remove unnecessary locking in follow-link
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
commit 8bacd1f7472c2c00a5fdd177ae8d2233a284b179
Author: Erez Zadok <[EMAIL PROTECTED]>
Date: Tue Dec 25 17:05:33 2007 -0500
Unionfs: remove unnecessary lock in read_inode
Our read_inode doesn't need to grab the superblock rwsem because there no
chance it could be affected by branch management. But our read_inode was
called from other places which did grab need to grab that rwsem, and lockdep
complained.
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
commit 36bbc586cc9d06c3ae2a4f299520cd6790517824
Author: Erez Zadok <[EMAIL PROTECTED]>
Date: Tue Dec 25 17:05:33 2007 -0500
Unionfs: remove unnecessary lock when deleting whiteouts
Lockdep complained, because we eventually call vfs_unlink which'd grab the
necessary locks.
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
commit 2b836bc94aa8bf7683ed53af3cb8bb963f5703f4
Author: Erez Zadok <[EMAIL PROTECTED]>
Date: Tue Dec 25 17:05:33 2007 -0500
Unionfs: remove unnecessary conditional inode lock
This was intended to protect the inode during branch management, but that is
now done through our superblock rwsem.
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
commit be43d7ac4346298c946731bc6422785cced6cc09
Author: Erez Zadok <[EMAIL PROTECTED]>
Date: Tue Dec 25 17:50:31 2007 -0500
Unionfs: prevent deadlock in cache coherency
Don't try to truncate_inode_pages in in purge_inode_data, because this could
lead to a deadlock between some of address_space ops and dentry
revalidation: the address space op is invoked with a lock on our own page,
and truncate_inode_pages will block on locked pages. Instead, it should be
enough to be gentler and just invalidate_mapping_pages.
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
commit 20aee4ba7f8f4bc16ec605364d8c2aa09ae1e293
Author: Erez Zadok <[EMAIL PROTECTED]>
Date: Tue Dec 25 17:05:33 2007 -0500
Unionfs: remove custom read/write methods
Having them results in lockdep warnings about having locks and grabbing the
same class locks in do_sync_read/write which were called from
unionfs_read/write. All they did was revalidate out file object sooner,
which will now be deferred till a bit later. Instead, use generic
do_sync_read and do_sync_write.
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
commit 1ff6c8064f5054834020f272fd19b6f2131c88c0
Author: Hugh Dickins <[EMAIL PROTECTED]>
Date: Fri Dec 28 13:41:50 2007 -0500
Unionfs: restructure unionfs_setattr and fix truncation order
Restructure the code to move the lower notify_change out of the loop in
unionfs_setattr. Cleanup and simplify the code. Then fix the truncation
order which fsx-linux in a unionfs on tmpfs found. Then handle copyup
properly.
When shrinking a file, unionfs_setattr needs to vmtruncate the upper level
before notifying change to the lower level, to eliminate those dirty pages
beyond new eof which otherwise drift down to the lower level's writepage,
writing beyond its eof (and later uncovered when the file is expanded).
Also truncate the upper level first when expanding, in the case when
the upper level's s_maxbytes is more limiting than the lower level's.
Signed-off-by: Hugh Dickins <[EMAIL PROTECTED]>
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
commit 0fd8c0f33b986043115bf1e555a3781d39cecb43
Author: Hugh Dickins <[EMAIL PROTECTED]>
Date: Tue Dec 25 17:05:33 2007 -0500
Unionfs: mmap fixes
Remove !mapping_cap_writeback_dirty shortcircuit from unionfs_writepages.
It was introduced to avoid the stray AOP_WRITEPAGE_ACTIVATE coming from
shmem_writepage; but that has since been fixed in shmem_writepage and in
write_cache_pages. It stayed because it looked like a good optimization,
not to waste time calling down to tmpfs when that would serve no purpose.
But in fact this optimization causes hangs when running LTP with unionfs
over tmpfs. The problem is that the test comes at the wrong level: unionfs
has already declared in its default_backing_dev_info that it's playing by
cap_writeback_dirty rules. If it does nothing here in its writepages, its
dirty pages accumulate and choke the system. What's needed is to carry on
down and let its pages be cleaned while in turn they dirty the lower level.
And this now has an additional benefit for tmpfs, that a sync or pdflush
pushes these pages down to shmem_writepage, letting it match the filepage
coming from unionfs with the swap which may have been allocated earlier,
so it can free the duplication sooner than waiting for further pressure.
Remove unnecessary locking/code from prepare_write. Handle if no lower
inodes in writepage.
Signed-off-by: Hugh Dickins <[EMAIL PROTECTED]>
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
commit b41a717b53e1358ef6d8cc203e82d8e97ac15519
Author: Erez Zadok <[EMAIL PROTECTED]>
Date: Tue Dec 25 17:05:33 2007 -0500
Unionfs: release special files on copyup
If we copyup a special file (char, block, etc.), then dput the source
object.
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
commit 82a8a9f3c9aa10499320649600f606b03ca2eff8
Author: Erez Zadok <[EMAIL PROTECTED]>
Date: Tue Dec 25 17:05:33 2007 -0500
Unionfs: create new symlinks only in first branch
When creating a new symlink, always create it in the first branch, which is
always writeable, not in the branch which may have a whiteout in it. This
makes the policy for the creation of new symlinks consistent with that of
new files/directories, as well as improves efficiency a bit.
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
commit 2a0200096521e794f5bbad8f54d8dcc6ccd8fa4b
Author: Erez Zadok <[EMAIL PROTECTED]>
Date: Tue Dec 25 17:05:33 2007 -0500
Unionfs: create new special files only in first branch
When creating a new special file, always create it in the first branch,
which is always writeable, not in the branch which may have a whiteout in
it. This makes the policy for the creation of new special files consistent
with that of new files/directories, as well as improves efficiency a bit.
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
commit 62ca8670ad50d9093d9f8d2c87125666e2ec6f00
Author: Erez Zadok <[EMAIL PROTECTED]>
Date: Tue Dec 25 17:05:33 2007 -0500
Unionfs: initialize inode times for reused inodes
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
commit 6167bfcb9ba134fa119d3cdd82dd91b2dd8d9e40
Author: Erez Zadok <[EMAIL PROTECTED]>
Date: Tue Dec 25 17:05:33 2007 -0500
Unionfs: interpose cleanup and fix for spliced dentries
Fix unionfs_interpose to fill lower inode info when d_splice_alias returns
NULL. Also cleanup impossible case (d_splice_alias doesn't return ERR_PTR).
Signed-off-by: Rachita Kothiyal <[EMAIL PROTECTED]>
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
commit b875cffce7810c3b008be85e00dc1062eb17411d
Author: Erez Zadok <[EMAIL PROTECTED]>
Date: Fri Dec 28 14:08:39 2007 -0500
Unionfs: clarify usage.txt read/write behavior
CC: Michael Tokarev <[EMAIL PROTECTED]>
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
commit 656865d568616e16198d0ea4bc5d87424d49f2a8
Author: Erez Zadok <[EMAIL PROTECTED]>
Date: Tue Dec 25 17:05:33 2007 -0500
Unionfs: use locking around i_size_write in 32-bit systems
CC: Hugh Dickins <[EMAIL PROTECTED]>
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
commit 68e7ec03418a32730c372c2d5be9b65cc79cda8e
Author: Hugh Dickins <[EMAIL PROTECTED]>
Date: Tue Dec 25 17:38:35 2007 -0500
VFS/fs_stack: use locking around i_size_write in 32-bit systems
LTP's iogen01 doio tests hang nicely on 32-bit SMP when /tmp is a unionfs
mount of a tmpfs. See the comment on i_size_write in linux/fs.h: it needs
to be locked, otherwise i_size_read can spin forever waiting for a lost
seqcount update.
Most filesystems are already holding i_mutex for this, but unionfs calls
fsstack_copy_inode_size from many places, not necessarily holding i_mutex.
Use the low-level i_lock within fsstack_copy_inode_size when 32-bit SMP.
Checked the entire unionfs code to ensure this is the right fix for
i_size_write().
Also compared to what other file systems do when they have to handle inodes,
esp. not their own inodes (e.g., network file systems have to access the
exported file system's inodes). Found out that most such file systems not
just
don't lock around i_size_write, but they don't even use i_size_read or
i_size_write to access the inode's size.
CC: Mike Halcrow <[EMAIL PROTECTED]>
Signed-off-by: Hugh Dickins <[EMAIL PROTECTED]>
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
commit 9308b3d6b98ca59336e00a113b6d1c05e9628eaa
Author: Erez Zadok <[EMAIL PROTECTED]>
Date: Tue Dec 25 17:05:33 2007 -0500
Unionfs: clarify usage.txt mount options
CC: Jim Kissel <[EMAIL PROTECTED]>
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
commit 58a5982ec69fdb441435a539d240d08314d1b909
Author: Erez Zadok <[EMAIL PROTECTED]>
Date: Tue Dec 25 17:05:33 2007 -0500
Unionfs: avoid using drop_pagecache_sb in remount
Exporting drop_pagecache_sb to modules is somewhat risky because one cannot
sleep inside invalidate_mapping_pages. This could cause a lot of latency in
the pre-emption code. So don't export this symbol to minimize the risk that
others will use it.
Instead, unionfs will try to directly invalidate as many pages it can from
the unionfs_remount code. Invalidating those inode pages is not strictly
required, but helpful in encouraging a revalidation of inodes sooner than
waiting for individual f/s ops to access the union. Since a remount is
already an expensive but rare operation, this inode pages invalidation
shouldn't add too much overhead.
CC: Nick Piggin <[EMAIL PROTECTED]>
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
_______________________________________________
unionfs-cvs mailing list: http://unionfs.filesystems.org/
[email protected]
http://www.fsl.cs.sunysb.edu/mailman/listinfo/unionfs-cvs
