commit b245c3b43439c715e33b57ca9b663123812dd208
Author: Carol Hebert <[EMAIL PROTECTED]>
Date:   Fri Apr 4 14:30:03 2008 -0700

    ipmi: change device node ordering to reflect probe order
    
    upstream commit: abd24df828f1a72971db29d1b74fefae104ea9e2
    
    In 2.6.14 a patch was merged which switching the order of the ipmi device
    naming from in-order-of-discovery over to reverse-order-of-discovery.
    
    So on systems with multiple BMC interfaces, the ipmi device names are being
    created in reverse order relative to how they are discovered on the system
    (e.g.  on an IBM x3950 multinode server with N nodes, the device name for 
the
    BMC in the first node is /dev/ipmiN-1 and the device name for the BMC in the
    last node is /dev/ipmi0, etc.).
    
    The problem is caused by the list handling routines chosen in dmi_scan.c.
    Using list_add() causes the multiple ipmi devices to be added to the device
    list using a stack-paradigm and so the ipmi driver subsequently pulls them 
off
    during initialization in LIFO order.  This patch changes the
    dmi_save_ipmi_device() list handling paradigm to a queue, thereby allowing 
the
    ipmi driver to build the ipmi device names in the order in which they are
    found on the system.
    
    Signed-off-by: Carol Hebert <[EMAIL PROTECTED]>
    Signed-off-by: Corey Minyard <[EMAIL PROTECTED]>
    Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
    Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>
    Signed-off-by: Chris Wright <[EMAIL PROTECTED]>

diff --git a/drivers/firmware/dmi_scan.c b/drivers/firmware/dmi_scan.c
index b2fb6ba..1c6440b 100644
--- a/drivers/firmware/dmi_scan.c
+++ b/drivers/firmware/dmi_scan.c
@@ -219,7 +219,7 @@ static void __init dmi_save_ipmi_device(const struct 
dmi_header *dm)
        dev->name = "IPMI controller";
        dev->device_data = data;
 
-       list_add(&dev->list, &dmi_devices);
+       list_add_tail(&dev->list, &dmi_devices);
 }
 
 /*
_______________________________________________
unionfs-cvs mailing list: http://unionfs.filesystems.org/
[email protected]
http://www.fsl.cs.sunysb.edu/mailman/listinfo/unionfs-cvs

Reply via email to