commit 0666c7890ea5cc978834e67fc25a8397cfd76fff
Author: Erez_Zadok <[EMAIL PROTECTED]>
Date: Mon Apr 30 16:48:20 2007 -0400
branch management: disallow setting leftmost branch to readonly
Unionfs requires the leftmost branch to be writeable for copyup to work
properly and simply. If, through branch-management commands (add, delete,
or mode change), the leftmost branch will becomes readonly, then return an
error (and tell the user to use "remount,ro" if they want a readonly union).
diff --git a/fs/unionfs/super.c b/fs/unionfs/super.c
index f6aa0ba..79114a9 100644
--- a/fs/unionfs/super.c
+++ b/fs/unionfs/super.c
@@ -643,12 +643,20 @@ static int unionfs_remount_fs(struct super_block *sb, int
*flags,
out_no_change:
/******************************************************************
- * WE'RE ALMOST DONE: see if we need to allocate a small-sized new
- * vector, copy the vectors to their correct place, release the
- * refcnt of the older ones, and return.
- * Also handle invalidating any pages that will have to be re-read.
+ * WE'RE ALMOST DONE: check if leftmost branch might be read-only,
+ * see if we need to allocate a small-sized new vector, copy the
+ * vectors to their correct place, release the refcnt of the older
+ * ones, and return. Also handle invalidating any pages that will
+ * have to be re-read.
*******************************************************************/
+ if (!(tmp_data[0].branchperms & MAY_WRITE)) {
+ printk("unionfs: leftmost branch cannot be read-only "
+ "(use \"remount,ro\" to create a read-only union)\n");
+ err = -EINVAL;
+ goto out_release;
+ }
+
/*
* Allocate space for actual pointers, if needed. By the time we
* finish this block of code, new_branches and new_lower_paths will
_______________________________________________
unionfs-cvs mailing list: http://unionfs.filesystems.org/
[email protected]
http://www.fsl.cs.sunysb.edu/mailman/listinfo/unionfs-cvs
