commit a51b5d8df8bd4b76812506a4c59eb388e8c7ae92
Author: Erez_Zadok <[EMAIL PROTECTED]>
Date:   Sat May 5 16:22:57 2007 -0400

    mmap: minor code and comment reformatting

diff --git a/fs/unionfs/file.c b/fs/unionfs/file.c
index c30dd8a..2bfc1f6 100644
--- a/fs/unionfs/file.c
+++ b/fs/unionfs/file.c
@@ -99,7 +99,7 @@ static int unionfs_mmap(struct file *file, struct 
vm_area_struct *vma)
 
        err = generic_file_mmap(file, vma);
        if (err)
-               printk("mmap: generic_file_mmap failed %d\n", err);
+               printk("unionfs: generic_file_mmap failed %d\n", err);
 
 out:
        unionfs_read_unlock(file->f_dentry->d_sb);
diff --git a/fs/unionfs/mmap.c b/fs/unionfs/mmap.c
index 99b3b2f..f484984 100644
--- a/fs/unionfs/mmap.c
+++ b/fs/unionfs/mmap.c
@@ -114,10 +114,10 @@ int unionfs_do_readpage(struct file *file, struct page 
*page)
        wait_on_page_locked(lower_page);
        if (!PageUptodate(lower_page)) {
                /*
-                * call readpage() again if we returned from wait_on_page with a
-                * page that's not up-to-date; that can happen when a partial
-                * page has a few buffers which are ok, but not the whole
-                * page.
+                * call readpage() again if we returned from wait_on_page
+                * with a page that's not up-to-date; that can happen when a
+                * partial page has a few buffers which are ok, but not the
+                * whole page.
                 */
                lock_page(lower_page);
                err = lower_inode->i_mapping->a_ops->readpage(lower_file,
@@ -168,9 +168,9 @@ int unionfs_readpage(struct file *file, struct page *page)
        err = unionfs_do_readpage(file, page);
 
        /*
-        * we have to unlock our page, b/c we _might_ have gotten a locked page.
-        * but we no longer have to wakeup on our page here, b/c UnlockPage does
-        * it
+        * we have to unlock our page, b/c we _might_ have gotten a locked
+        * page.  but we no longer have to wakeup on our page here, b/c
+        * UnlockPage does it
         */
 
 out_err:
@@ -255,14 +255,13 @@ sector_t unionfs_bmap(struct address_space * mapping, 
sector_t block)
 {
        int err = 0;
        struct inode *inode, *lower_inode;
+       sector_t (*bmap)(struct address_space *, sector_t);
 
        inode = (struct inode *)mapping->host;
        lower_inode = unionfs_lower_inode(inode);
-
-       if (lower_inode->i_mapping->a_ops->bmap)
-               err =
-                   lower_inode->i_mapping->a_ops->bmap(lower_inode->i_mapping,
-                                                       block);
+       bmap = lower_inode->i_mapping->a_ops->bmap;
+       if (bmap)
+               err = bmap(lower_inode->i_mapping, block);
        return err;
 }
 
@@ -301,4 +300,3 @@ struct address_space_operations unionfs_aops = {
        .bmap           = unionfs_bmap,
        .sync_page      = unionfs_sync_page,
 };
-
_______________________________________________
unionfs-cvs mailing list: http://unionfs.filesystems.org/
[email protected]
http://www.fsl.cs.sunysb.edu/mailman/listinfo/unionfs-cvs

Reply via email to