commit e5468419f65b24ffa42d24d0fd61b36ca0dc30e0
Author: Erez Zadok <[email protected]>
Date: Tue Sep 22 17:33:46 2009 -0400
Unionfs: fix readonly nfs2/3 permission handling
In unionfs_permission: NFSv2/3 return EACCES on readonly-exported, locally
readonly-mounted file systems, instead of EROFS like other file systems do.
So we have no choice here but to intercept this and ignore it for NFS
branches marked readonly. Specifically, we avoid using NFS's own "broken"
->permission method, and rely on generic_permission() to do basic checking
for us.
Signed-off-by: Erez Zadok <[email protected]>
diff --git a/fs/unionfs/inode.c b/fs/unionfs/inode.c
index 9ab7b8e..6a01341 100644
--- a/fs/unionfs/inode.c
+++ b/fs/unionfs/inode.c
@@ -838,6 +838,20 @@ static int unionfs_permission(struct inode *inode, int
mask,
}
/*
+ * NFS HACK: NFSv2/3 return EACCES on readonly-exported,
+ * locally readonly-mounted file systems, instead of EROFS
+ * like other file systems do. So we have no choice here
+ * but to intercept this and ignore it for NFS branches
+ * marked readonly. Specifically, we avoid using NFS's own
+ * "broken" ->permission method, and rely on
+ * generic_permission() to do basic checking for us.
+ */
+ if (err && err == -EACCES &&
+ is_robranch_super(inode->i_sb, bindex) &&
+ lower_inode->i_sb->s_magic == NFS_SUPER_MAGIC)
+ err = generic_permission(lower_inode, mask, NULL);
+
+ /*
* The permissions are an intersection of the overall directory
* permissions, so we fail if one fails.
*/
_______________________________________________
unionfs-cvs mailing list: http://unionfs.filesystems.org/
[email protected]
http://www.fsl.cs.sunysb.edu/mailman/listinfo/unionfs-cvs
