Hi!!

> > I've just released Unionfs 1.1.1.  The real important change is that
> 
> just failed to make this version with -DNFS_SECURITY_HOLE.
> 
> With the following patch according to Junjiro's original patch
> make was successfull.
> 
> Regards,
> Martin
> 
> --- inode.c.orig      2005-10-26 03:13:36.000000000 +0200
> +++ inode.c   2005-10-26 15:21:56.830011204 +0200
> @@ -826,7 +826,7 @@
>  
>  /* Basically copied from the kernel vfs permission(), but we've changed
>   * the following: (1) the IS_RDONLY check is skipped, and (2) if you define
> - * -DNFS_SECURITY_HOLE, we assume that -EACCESS means that the export is
> + * -DNFS_SECURITY_HOLE, we assume that -EACCES means that the export is
>   * read-only and we should check standard Unix permissions.  This means
>   * that NFS ACL checks (or other advanced permission features) are bypassed.
>   */
> @@ -855,8 +855,8 @@
>       if (inode->i_op && inode->i_op->permission) {
>               retval = inode->i_op->permission(inode, submask, nd);
>  #ifdef NFS_SECURITY_HOLE
> -#define IS_NFS(inode) (strcmp("nfs", (inode)->i_sb->s_type->s_name))
> -             if ((retval == -EACCESS) && (submask & MAY_WRITE) &&
> +#define IS_NFS(inode) (strncmp("nfs", (inode)->i_sb->s_type->name, 4) == 0)
> +             if ((retval == -EACCES) && (submask & MAY_WRITE) &&
>                   IS_NFS(inode)) {
>                       retval = generic_permission(inode, submask, NULL);
>               }

Just with this patch applied I was able to compile the code - otherwise 
not (--> unionfs-20051025-2113) ...

I will try it out as soon as possible!

Thanks!! Dirk

_______________________________________________
unionfs mailing list
unionfs@mail.fsl.cs.sunysb.edu
http://www.fsl.cs.sunysb.edu/mailman/listinfo/unionfs

Reply via email to