IRC discussion from #ubuntu-desktop: [09:16:50] <charles> hmm, I wonder if there's a better way to do things like this so that we don't wind up with #ifdef-level code all over the place [09:16:55] <charles> https://code.launchpad.net/~445865575-b/indicator-session/indicatorForKylin/+merge/223664 [09:20:31] <Laney> maybe they should divert /etc/os-release or something [09:29:15] <seb128> charles, what laney said, use NAME from /etc/os-release and get Kylin to change that [09:29:36] <seb128> like "%s Help", NAME [09:30:19] <seb128> happyaron, FJKong: do you if Kylin change its /etc/os-release? [09:30:50] <happyaron> seb128: Kylin does not change it atm [09:32:37] <seb128> happyaron, do you know if they discussed change it? [09:34:43] <happyaron> seb128: they didn't [09:35:26] <happyaron> seb128: they added a file, /etc/ubuntukylin-release, for identifying Kylin systems. [09:35:52] <Laney> it means that programs have to special case kylin though [09:35:55] <seb128> happyaron, well, that forces code to special case rather than just reading os-release [09:37:42] <happyaron> seb128: they want to keep compatibility with Ubuntu as much as possible, so that all program that do OS checking can identify it as Ubuntu, except those ones can recognize the additional indication of Kylin flavor. [09:37:58] <seb128> shrug [09:38:09] <seb128> they want to be Ubuntu but not be flagged as Ubuntu at the same time [09:38:23] <happyaron> that's it [09:39:02] <Laney> http://www.freedesktop.org/software/systemd/man/os-release.html [09:39:06] <Laney> I think that NAME is for presentation
Anthony, is there harm in changing the presentation name in /etc/os- release? What breaks if we set NAME=Kylin Ubuntu there? -- You received this bug notification because you are a member of Unity API bugs, which is subscribed to Session Menu. https://bugs.launchpad.net/bugs/1331873 Title: the "Ubuntu Help" should be "Ubuntu Kylin Help" Status in The Session Menu: New Status in Ubuntu Kylin: New Bug description: the "Ubuntu Help"should be "Ubuntu Kuliy Help" in the indicator ,since this is ubuntuKylin system. To manage notifications about this bug go to: https://bugs.launchpad.net/indicator-session/+bug/1331873/+subscriptions -- Mailing list: https://launchpad.net/~unity-api-bugs Post to : [email protected] Unsubscribe : https://launchpad.net/~unity-api-bugs More help : https://help.launchpad.net/ListHelp
