For the most part, this looks good but I do have a few questions: 1. Your changelog makes it seem like you've modified src/EBox/Apache.pm inline. However, if I've read your debdiff correctly it looks like the change is made by your 17_dbus_gconf.dpatch patch. If the former is the case, please do not make the change inline. If the later, please update your changelog entry. You can have your sponsor do this - no need to prepare another debdiff for this at this time. 2. Can you confirm that the dbus changes are counterpart changes to the SRU in bug #314606? If so, please note this in your changelog. You can have your sponsor do this - no need to prepare another debdiff for this at this time. 3. I assume that 16_add_apache_authcookie.dpatch is copying and pasting the file(s) you need from that package that got removed? Can you confirm or explain where they came from if my assumption is wrong? 4. Also, I see that you note that this has not been fixed in Jaunty. Could you please explain why this is the case? Are you just getting a head start on the SRU or are you looking for this SRU to be accepted without the fix first being in Jaunty?
-- ebox: Depends: libapache-authcookie-perl but it is not installable https://bugs.launchpad.net/bugs/255368 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-b...@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs -- universe-bugs mailing list universe-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/universe-bugs
