syncLocalToLocal should use U1db::Database to re-use the initialization, which would also give it the existing sanity checks
the logic of onSyncChanged is probably best moved into a separate callback. Changing resolve_to_source and targets would trigger it as well. Thus it becomes possible to delay/ thread the real sync and avoid any delay at startup. Even with keeping in mind it's incomplete //uncommented code and conflicts make reviewing a little hard. I love the description of the sync via HTTP/ JSON, this would be nice to get into one qdoc-ified comment and make it accessible as documentation. -- https://code.launchpad.net/~kevin-wright-1/u1db-qt/synchronizer-18-juni-i/+merge/170623 Your team U1DB Qt developers is requested to review the proposed merge of lp:~kevin-wright-1/u1db-qt/synchronizer-18-juni-i into lp:u1db-qt. -- Mailing list: https://launchpad.net/~uonedb-qt Post to : [email protected] Unsubscribe : https://launchpad.net/~uonedb-qt More help : https://help.launchpad.net/ListHelp
