Re: [uportal-dev] maven plugin won't build with ResourcesAggregatorImplTest

[Susan Bramhall]

Yes, D: is local and same file system as running mvn on. I do have delete on that directory and can delete it manually.  Susan Nicholas Blair wrote: There is a method annotated with @After (runs "after" each test) to clean up temporary files created by the test. The tests use the System property java.io.tmpdir to use as a root for these temporary files. I don't really know much about why that wouldn't work on windows....do you have permission to delete files under d:\susan\temp? Is your d: drive a local or a remote filesystem? On Mon, Nov 16, 2009 at 3:27 PM, Susan Bramhall <susan.bramh...@yale.edu> wrote: Thanks to you both I am now down to just the errors caused by unable to delete temp files: java.io.IOException: Unable to delete file: d:\susan\temp\1\resources-aggregator-impl-test-output\skin-test1\uportal3_aggr2_temp.js One for each test in ResourcesAggregatorImplTest. Not sure why I get that and you don't. I am running under windows which does not like to delete open files. Maybe this is not getting closed? Susan Nicholas Blair wrote: I've just checked in the changes necessary to fix the tests - you should not have any problem building maven-uportal-plugin if you update to the trunk. On Mon, Nov 16, 2009 at 2:07 PM, Nicholas Blair <nicholas.bl...@gmail.com> wrote: Excellent - I'll get the projects updated. Thanks! On Mon, Nov 16, 2009 at 1:50 PM, Jen Bourey <jbou...@unicon.net> wrote: Hi Nick, I've added the yuicompressor 2.4.2 jar to the Jasig third party repository (http://developer.jasig.org/repo/content/repositories/3rd-party/). - Jen On Mon, Nov 16, 2009 at 2:38 PM, Nicholas Blair <nicholas.bl...@gmail.com> wrote: This was related to my prior discussion about YUI Compressor and UP-2505. In short, the only YUI Compressor available via maven is version 2.3.6 - which is broken. I have installed 2.4.2 locally, and modified the pom to use it, and verified it works. Per my last comment on http://www.ja-sig.org/issues/browse/UP-2505 - this task is "complete-able" if we can get YUI Compressor 2.4.2 in a maven repository. If we can do that, I can make the last commits to get the "resource aggregator" mojo in the maven-uportal-plugin ready for use. On Mon, Nov 16, 2009 at 1:18 PM, Susan Bramhall <susan.bramh...@yale.edu> wrote: I've updated the maven plugin to throw the proper failure exception when appropriate so it does not end with BUILD SUCCESSFUL after a failure. Integrating this change in, I picked up some recent changes committed by Nick Blair. These seem to be setting up for new skin function in up 3.2. I'm assuming this is all no problem for people using the plugin for uP 3.1. However, the plugin will no longer build for me. I get test failures on the build (see stack trace below). I'd be grateful to know if this builds for other people. Nick? I think it might be a good idea to tag this so we can have a stable version for our use in production while preparation for future uPortal function is added. Thanks, Susan surefire report: =========== ------------------------------------------------------------------------------- Test set: org.jasig.portal.web.skin.ResourcesAggregatorImplTest ------------------------------------------------------------------------------- Tests run: 5, Failures: 0, Errors: 5, Skipped: 0, Time elapsed: 0.313 sec <<< FAILURE! testControl(org.jasig.portal.web.skin.ResourcesAggregatorImplTest) Time elapsed: 0.25 sec <<< ERROR! java.lang.RuntimeException at com.yahoo.platform.yui.compressor._javascript_Compressor.printSourceNumber(_javascript_Compressor.java:299) at com.yahoo.platform.yui.compressor._javascript_Compressor.parse(_javascript_Compressor.java:335) at com.yahoo.platform.yui.compressor._javascript_Compressor.<init>(_javascript_Compressor.java:532) at org.jasig.portal.web.skin.ResourcesAggregatorImpl.aggregateJsList(ResourcesAggregatorImpl.java:418) at org.jasig.portal.web.skin.ResourcesAggregatorImpl.aggregate(ResourcesAggregatorImpl.java:226) at org.jasig.portal.web.skin.ResourcesAggregatorImplTest.testControl(ResourcesAggregatorImplTest.java:34) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.junit.internal.runners.TestMethod.invoke(TestMethod.java:59) at org.junit.internal.runners.MethodRoadie.runTestMethod(MethodRoadie.java:98) at org.junit.internal.runners.MethodRoadie$2.run(MethodRoadie.java:79) at org.junit.internal.runners.MethodRoadie.runBeforesThenTestThenAfters(MethodRoadie.java:87) at org.junit.internal.runners.MethodRoadie.runTest(MethodRoadie.java:77) at org.junit.internal.runners.MethodRoadie.run(MethodRoadie.java:42) at org.junit.internal.runners.JUnit4ClassRunner.invokeTestMethod(JUnit4ClassRunner.java:88) at org.junit.internal.runners.JUnit4ClassRunner.runMethods(JUnit4ClassRunner.java:51) at org.junit.internal.runners.JUnit4ClassRunner$1.run(JUnit4ClassRunner.java:44) at org.junit.internal.runners.ClassRoadie.runUnprotected(ClassRoadie.java:27) at org.junit.internal.runners.ClassRoadie.runProtected(ClassRoadie.java:37) at org.junit.internal.runners.JUnit4ClassRunner.run(JUnit4ClassRunner.java:42) at org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:62) at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140) at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:127) at org.apache.maven.surefire.Surefire.run(Surefire.java:177) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:345) at org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1009) testControl(org.jasig.portal.web.skin.ResourcesAggregatorImplTest) Time elapsed: 0.266 sec <<< ERROR! java.io.IOException: Unable to delete file: d:\susan\temp\1\resources-aggregator-impl-test-output\skin-test1\uportal3_aggr2_temp.js at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:1390) at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:1044) at org.apache.commons.io.FileUtils.deleteDirectory(FileUtils.java:977) at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:1381) at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:1044) at org.apache.commons.io.FileUtils.deleteDirectory(FileUtils.java:977) at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:1381) at org.jasig.portal.web.skin.ResourcesAggregatorImplTest.cleanupTempDir(ResourcesAggregatorImplTest.java:146) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.junit.internal.runners.MethodRoadie.runAfters(MethodRoadie.java:138) at org.junit.internal.runners.MethodRoadie.runBeforesThenTestThenAfters(MethodRoadie.java:92) at org.junit.internal.runners.MethodRoadie.runTest(MethodRoadie.java:77) at org.junit.internal.runners.MethodRoadie.run(MethodRoadie.java:42) at org.junit.internal.runners.JUnit4ClassRunner.invokeTestMethod(JUnit4ClassRunner.java:88) at org.junit.internal.runners.JUnit4ClassRunner.runMethods(JUnit4ClassRunner.java:51) at org.junit.internal.runners.JUnit4ClassRunner$1.run(JUnit4ClassRunner.java:44) at org.junit.internal.runners.ClassRoadie.runUnprotected(ClassRoadie.java:27) at org.junit.internal.runners.ClassRoadie.runProtected(ClassRoadie.java:37) at org.junit.internal.runners.JUnit4ClassRunner.run(JUnit4ClassRunner.java:42) at org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:62) at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140) at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:127) at org.apache.maven.surefire.Surefire.run(Surefire.java:177) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:345) at org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1009) testAllAbsolute(org.jasig.portal.web.skin.ResourcesAggregatorImplTest) Time elapsed: 0.015 sec <<< ERROR! java.io.IOException: Unable to delete file: d:\susan\temp\1\resources-aggregator-impl-test-output\skin-test1\uportal3_aggr2_temp.js at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:1390) at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:1044) at org.apache.commons.io.FileUtils.deleteDirectory(FileUtils.java:977) at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:1381) at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:1044) at org.apache.commons.io.FileUtils.deleteDirectory(FileUtils.java:977) at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:1381) at org.jasig.portal.web.skin.ResourcesAggregatorImplTest.cleanupTempDir(ResourcesAggregatorImplTest.java:146) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.junit.internal.runners.MethodRoadie.runAfters(MethodRoadie.java:138) at org.junit.internal.runners.MethodRoadie.runBeforesThenTestThenAfters(MethodRoadie.java:92) at org.junit.internal.runners.MethodRoadie.runTest(MethodRoadie.java:77) at org.junit.internal.runners.MethodRoadie.run(MethodRoadie.java:42) at org.junit.internal.runners.JUnit4ClassRunner.invokeTestMethod(JUnit4ClassRunner.java:88) at org.junit.internal.runners.JUnit4ClassRunner.runMethods(JUnit4ClassRunner.java:51) at org.junit.internal.runners.JUnit4ClassRunner$1.run(JUnit4ClassRunner.java:44) at org.junit.internal.runners.ClassRoadie.runUnprotected(ClassRoadie.java:27) at org.junit.internal.runners.ClassRoadie.runProtected(ClassRoadie.java:37) at org.junit.internal.runners.JUnit4ClassRunner.run(JUnit4ClassRunner.java:42) at org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:62) at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140) at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:127) at org.apache.maven.surefire.Surefire.run(Surefire.java:177) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:345) at org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1009) testComplex(org.jasig.portal.web.skin.ResourcesAggregatorImplTest) Time elapsed: 0.016 sec <<< ERROR! java.lang.RuntimeException at com.yahoo.platform.yui.compressor._javascript_Compressor.printSourceNumber(_javascript_Compressor.java:299) at com.yahoo.platform.yui.compressor._javascript_Compressor.parse(_javascript_Compressor.java:335) at com.yahoo.platform.yui.compressor._javascript_Compressor.<init>(_javascript_Compressor.java:532) at org.jasig.portal.web.skin.ResourcesAggregatorImpl.aggregateJsList(ResourcesAggregatorImpl.java:418) at org.jasig.portal.web.skin.ResourcesAggregatorImpl.aggregate(ResourcesAggregatorImpl.java:213) at org.jasig.portal.web.skin.ResourcesAggregatorImplTest.testComplex(ResourcesAggregatorImplTest.java:101) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.junit.internal.runners.TestMethod.invoke(TestMethod.java:59) at org.junit.internal.runners.MethodRoadie.runTestMethod(MethodRoadie.java:98) at org.junit.internal.runners.MethodRoadie$2.run(MethodRoadie.java:79) at org.junit.internal.runners.MethodRoadie.runBeforesThenTestThenAfters(MethodRoadie.java:87) at org.junit.internal.runners.MethodRoadie.runTest(MethodRoadie.java:77) at org.junit.internal.runners.MethodRoadie.run(MethodRoadie.java:42) at org.junit.internal.runners.JUnit4ClassRunner.invokeTestMethod(JUnit4ClassRunner.java:88) at org.junit.internal.runners.JUnit4ClassRunner.runMethods(JUnit4ClassRunner.java:51) at org.junit.internal.runners.JUnit4ClassRunner$1.run(JUnit4ClassRunner.java:44) at org.junit.internal.runners.ClassRoadie.runUnprotected(ClassRoadie.java:27) at org.junit.internal.runners.ClassRoadie.runProtected(ClassRoadie.java:37) at org.junit.internal.runners.JUnit4ClassRunner.run(JUnit4ClassRunner.java:42) at org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:62) at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140) at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:127) at org.apache.maven.surefire.Surefire.run(Surefire.java:177) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:345) at org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1009) testComplex(org.jasig.portal.web.skin.ResourcesAggregatorImplTest) Time elapsed: 0.016 sec <<< ERROR! java.io.IOException: Unable to delete file: d:\susan\temp\1\resources-aggregator-impl-test-output\skin-test1\uportal3_aggr2_temp.js at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:1390) at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:1044) at org.apache.commons.io.FileUtils.deleteDirectory(FileUtils.java:977) at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:1381) at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:1044) at org.apache.commons.io.FileUtils.deleteDirectory(FileUtils.java:977) at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:1381) at org.jasig.portal.web.skin.ResourcesAggregatorImplTest.cleanupTempDir(ResourcesAggregatorImplTest.java:146) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.junit.internal.runners.MethodRoadie.runAfters(MethodRoadie.java:138) at org.junit.internal.runners.MethodRoadie.runBeforesThenTestThenAfters(MethodRoadie.java:92) at org.junit.internal.runners.MethodRoadie.runTest(MethodRoadie.java:77) at org.junit.internal.runners.MethodRoadie.run(MethodRoadie.java:42) at org.junit.internal.runners.JUnit4ClassRunner.invokeTestMethod(JUnit4ClassRunner.java:88) at org.junit.internal.runners.JUnit4ClassRunner.runMethods(JUnit4ClassRunner.java:51) at org.junit.internal.runners.JUnit4ClassRunner$1.run(JUnit4ClassRunner.java:44) at org.junit.internal.runners.ClassRoadie.runUnprotected(ClassRoadie.java:27) at org.junit.internal.runners.ClassRoadie.runProtected(ClassRoadie.java:37) at org.junit.internal.runners.JUnit4ClassRunner.run(JUnit4ClassRunner.java:42) at org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:62) at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140) at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:127) at org.apache.maven.surefire.Surefire.run(Surefire.java:177) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:345) at org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1009) -- Susan Bramhall (susan.bramh...@yale.edu) Senior Developer, Infrastructure Systems and Architecture (formerly T&P) Yale University Information Technology Services (ITS) 25 Science Park, 150 Munson St, New Haven, CT 06520 Phone: 203 432 6697 -- You are currently subscribed to uportal-dev@lists.ja-sig.org as: nicholas.bl...@gmail.com To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/uportal-dev -- You are currently subscribed to uportal-dev@lists.ja-sig.org as: jennifer.bou...@gmail.com To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/uportal-dev -- Jen Bourey -- You are currently subscribed to uportal-dev@lists.ja-sig.org as: nicholas.bl...@gmail.com To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/uportal-dev -- You are currently subscribed to uportal-dev@lists.ja-sig.org as: susan.bramh...@yale.edu To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/uportal-dev -- Susan Bramhall (susan.bramh...@yale.edu) Senior Developer, Infrastructure Systems and Architecture (formerly T&P) Yale University Information Technology Services (ITS) 25 Science Park, 150 Munson St, New Haven, CT 06520 Phone: 203 432 6697 -- You are currently subscribed to uportal-dev@lists.ja-sig.org as: nicholas.bl...@gmail.com To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/uportal-dev -- You are currently subscribed to uportal-dev@lists.ja-sig.org as: susan.bramh...@yale.edu To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/uportal-dev -- Susan Bramhall (susan.bramh...@yale.edu) Senior Developer, Infrastructure Systems and Architecture (formerly T&P) Yale University Information Technology Services (ITS) 25 Science Park, 150 Munson St, New Haven, CT 06520 Phone:  203 432 6697 -- You are currently subscribed to uportal-dev@lists.ja-sig.org as: arch...@mail-archive.com To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/uportal-dev