Dmitrijs Ledkovs has proposed merging lp:~xnox/upstart/fix-qemu-test into 
lp:upstart.

Requested reviews:
  Upstart Reviewers (upstart-reviewers)

For more details, see:
https://code.launchpad.net/~xnox/upstart/fix-qemu-test/+merge/137517

Fix the failed path typo: the log filename is not defined and hence the unlink 
will always fail.
-- 
https://code.launchpad.net/~xnox/upstart/fix-qemu-test/+merge/137517
Your team Upstart Reviewers is requested to review the proposed merge of 
lp:~xnox/upstart/fix-qemu-test into lp:upstart.
=== modified file 'init/tests/test_job_process.c'
--- init/tests/test_job_process.c	2012-12-03 09:40:15 +0000
+++ init/tests/test_job_process.c	2012-12-03 10:02:25 +0000
@@ -4793,8 +4793,8 @@
 		TEST_ALLOC_SAFE {
 			/* May alloc space if there is log data */
 			nih_free (class);
+			TEST_GT (sprintf (filename, "%s/simple-test.log", dirname), 0);
 			if (!test_alloc_failed) {
-				TEST_GT (sprintf (filename, "%s/simple-test.log", dirname), 0);
 				output = fopen (filename, "r");
 				TEST_NE_P (output, NULL);
 				CHECK_FILE_EQ (output, "hello world\r\n", TRUE);

-- 
upstart-devel mailing list
[email protected]
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/upstart-devel

Reply via email to