------------------------------------------------------------ revno: 1395 committer: James Hunt <[email protected]> branch nick: upstart timestamp: Tue 2012-12-04 17:12:46 +0000 message: * init/tests/test_job_process.c: test_run(): Set process->script explicitly for multiple tests to avoid undefined behaviour where a shell may or may not be used (LP: #1086474). modified: init/tests/test_job_process.c
-- lp:upstart https://code.launchpad.net/~upstart-devel/upstart/trunk Your team Upstart Reviewers is subscribed to branch lp:upstart. To unsubscribe from this branch go to https://code.launchpad.net/~upstart-devel/upstart/trunk/+edit-subscription
=== modified file 'init/tests/test_job_process.c' --- init/tests/test_job_process.c 2012-12-03 09:59:48 +0000 +++ init/tests/test_job_process.c 2012-12-04 17:12:46 +0000 @@ -648,6 +648,7 @@ class = job_class_new (NULL, "test", NULL); class->console = CONSOLE_NONE; class->process[PROCESS_MAIN] = process_new (class); + class->process[PROCESS_MAIN]->script = FALSE; class->process[PROCESS_MAIN]->command = nih_sprintf ( class->process[PROCESS_MAIN], "%s %d %s", argv0, TEST_ENVIRONMENT, filename); @@ -701,6 +702,7 @@ class = job_class_new (NULL, "test", NULL); class->console = CONSOLE_NONE; class->process[PROCESS_MAIN] = process_new (class); + class->process[PROCESS_MAIN]->script = FALSE; class->process[PROCESS_MAIN]->command = nih_sprintf ( class->process[PROCESS_MAIN], "%s %d %s", argv0, TEST_ENVIRONMENT, filename); @@ -755,6 +757,7 @@ class = job_class_new (NULL, "test", NULL); class->console = CONSOLE_NONE; class->process[PROCESS_PRE_STOP] = process_new (class); + class->process[PROCESS_PRE_STOP]->script = FALSE; class->process[PROCESS_PRE_STOP]->command = nih_sprintf ( class->process[PROCESS_PRE_STOP], "%s %d %s", argv0, TEST_ENVIRONMENT, filename); @@ -810,6 +813,7 @@ class = job_class_new (NULL, "test", NULL); class->console = CONSOLE_NONE; class->process[PROCESS_POST_STOP] = process_new (class); + class->process[PROCESS_POST_STOP]->script = FALSE; class->process[PROCESS_POST_STOP]->command = nih_sprintf ( class->process[PROCESS_POST_STOP], "%s %d %s", argv0, TEST_ENVIRONMENT, filename); @@ -933,6 +937,7 @@ class = job_class_new (NULL, "test", NULL); class->console = CONSOLE_NONE; class->process[PROCESS_MAIN] = process_new (class); + class->process[PROCESS_MAIN]->script = FALSE; class->process[PROCESS_MAIN]->command = "true"; job = job_new (class, ""); @@ -972,6 +977,7 @@ class = job_class_new (NULL, "test", NULL); class->console = CONSOLE_NONE; class->process[PROCESS_PRE_START] = process_new (class); + class->process[PROCESS_PRE_START]->script = FALSE; class->process[PROCESS_PRE_START]->command = "true"; job = job_new (class, ""); @@ -1013,6 +1019,7 @@ class->console = CONSOLE_NONE; class->expect = EXPECT_DAEMON; class->process[PROCESS_MAIN] = process_new (class); + class->process[PROCESS_MAIN]->script = FALSE; class->process[PROCESS_MAIN]->command = "true"; job = job_new (class, ""); @@ -1063,6 +1070,7 @@ class->console = CONSOLE_NONE; class->expect = EXPECT_FORK; class->process[PROCESS_MAIN] = process_new (class); + class->process[PROCESS_MAIN]->script = FALSE; class->process[PROCESS_MAIN]->command = "true"; job = job_new (class, ""); @@ -1113,6 +1121,7 @@ class = job_class_new (NULL, "test", NULL); class->console = CONSOLE_NONE; class->process[PROCESS_MAIN] = process_new (class); + class->process[PROCESS_MAIN]->script = FALSE; class->process[PROCESS_MAIN]->command = filename; job = job_new (class, "foo");
-- upstart-devel mailing list [email protected] Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/upstart-devel
