Stéphane Graber has proposed merging lp:~stgraber/upstart/upstart-tests-pty into lp:upstart.
Requested reviews: Upstart Reviewers (upstart-reviewers) For more details, see: https://code.launchpad.net/~stgraber/upstart/upstart-tests-pty/+merge/140388 This fixes our current PPA build hang. PPA don't allow writting to /dev/tty (for some weird reason), so upstart uses a pty instead. However the function setting up the pty was a bit wrong as it was doing a waitpid on the child before starting the mainloop watching for the output coming to the pty. So as soon as the pty buffer was full, everything would hang. This simply moves the mainloop start before the waitpid, fixing the hang. -- https://code.launchpad.net/~stgraber/upstart/upstart-tests-pty/+merge/140388 Your team Upstart Reviewers is requested to review the proposed merge of lp:~stgraber/upstart/upstart-tests-pty into lp:upstart.
=== modified file 'init/tests/test_job_process.c' --- init/tests/test_job_process.c 2012-12-17 11:27:01 +0000 +++ init/tests/test_job_process.c 2012-12-18 11:06:58 +0000 @@ -9198,6 +9198,8 @@ io_error_handler, NULL); TEST_NE_P (io, NULL); + ret = nih_main_loop (); + /* wait for child to finish */ TEST_EQ (waitpid (pid, &status, 0), pid); @@ -9207,7 +9209,6 @@ WIFSTOPPED (status) ? WSTOPSIG (status) : EXIT_FAILURE; - ret = nih_main_loop (); exit (exit_status ? exit_status : ret); }
-- upstart-devel mailing list [email protected] Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/upstart-devel
