> * extra/upstart-event-bridge.c: main(): > - Looks like user_session_path should be nih_local, whilst path_element > should just be 'char *'?
Done. While testing that change, I also noticed a couple more that shouldn't be nih_local as they were causing segfaults in daemon mode. I didn't spot those earlier because I didn't think of running the daemon under strace to catch any potential segfault on exit of the child. > - If $HOME is not set, we fail to start. That's probably reasonable though > as we display a couple > of errors in that scenario. Right, the only other thing I could think of was trying to write in CWD but if HOME isn't set, it's fairly likely to be somewhere you can't write to anyway (or shouldn't at least). The main problem here is that libnih doesn't let you use the daemonise function without also creating a pidfile. -- https://code.launchpad.net/~stgraber/upstart/upstart-make-event-bridge-usable/+merge/144399 Your team Upstart Reviewers is subscribed to branch lp:upstart. -- upstart-devel mailing list [email protected] Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/upstart-devel
