Review: Needs Fixing

* Remove ; at the end of rule "cp $< $@;" for aesthetic reasons =)
* upstart-dbus.h should be added to BUILT_SOURCES variable
* Fails to compile:

make[3]: Entering directory `/home/xnox/canonical/upstart/upstart/lib'
  CC       test_libupstart.o
In file included from tests/test_libupstart.c:37:0:
./upstart.h:27:34: fatal error: upstart/upstart-dbus.h: No such file or 
directory
 #include "upstart/upstart-dbus.h"
                                  ^
compilation terminated.
make[3]: *** [test_libupstart.o] Error 1



-- 
https://code.launchpad.net/~jamesodhunt/upstart/fix-libupstart/+merge/172371
Your team Upstart Reviewers is subscribed to branch lp:upstart.

-- 
upstart-devel mailing list
[email protected]
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/upstart-devel

Reply via email to