On 05/27/2013 09:11 AM, Adam Chlipala wrote:
Looks pretty good to me! A few observations:
- Why did you decide to parametrize your main functor over both a mode
and a function from modes to CSS classes? The functor implementation
seems to use the function and mode only by
applying the former to the latter, so why not just pass in a CSS class?
You're right, the class selector function shouldn't be parametrized. I
do however want it to be parametrized by mode because I don't want
arbitrary css classes being passed in.
- Personally, I'd opt for the identifier [navBarClass] over
[getNavBarClass], since the former feels more functional-ish.
Agreed. Still getting used to a declarative mindset.
- There seem to be many extra blank lines at the end of the .ur file.
Derp.
On 05/23/2013 04:33 AM, David Snider wrote:
I've started writing a library that wraps the 'gui' library to
produce widgets styled with twitter bootstrap.
I would appreciate if somebody could take a quick look at a simple
example I've done and tell me if I am using the language correctly.
Thanks
https://github.com/sniderd/bootstrap_gui
_______________________________________________
Ur mailing list
[email protected]
http://www.impredicative.com/cgi-bin/mailman/listinfo/ur
_______________________________________________
Ur mailing list
[email protected]
http://www.impredicative.com/cgi-bin/mailman/listinfo/ur
