On Thursday 04 February 2010 11:42:40 Jie Zhang wrote: > On 02/05/2010 12:28 AM, Mike Frysinger wrote: > > On Thursday 04 February 2010 09:12:09 Jie Zhang wrote: > >> Please revert r1748. We cannot use the common > >> urj_tap_register_get_value() for Blackfin emulation registers. MSB is > >> the first bit shifted out for those registers, which is different with > >> other parts. That's why we have Blackfin specific register_value and > >> register_init_value functions. > > > > how about we add a common function that handles the swapping ? > > urj_jtag_to_cpu() ? > > I don't see much benefit of adding this. I'm afraid only Blackfin needs > this. Others should all conform to the standard.
i doubt our designers are the only ones who made this choice :) > Anyway if you want to make it perfect, I think it would be better to add an > attribute to register, named for example as lsb_first, which is true by > default and set to false for all Blackfin emulation registers. Then > register_get_value and register_set_value need to look at this attribute > and do accordingly. ah, even better idea. this would involve extending the "instruction" syntax such that it takes another argument that declares its endianness ? -mike
signature.asc
Description: This is a digitally signed message part.
------------------------------------------------------------------------------ The Planet: dedicated and managed hosting, cloud storage, colocation Stay online with enterprise data centers and the best network in the business Choose flexible plans and management services without long-term contracts Personal 24x7 support from experience hosting pros just a phone call away. http://p.sf.net/sfu/theplanet-com
_______________________________________________ UrJTAG-development mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/urjtag-development
