On Friday, September 10, 2010 18:21:31 Michael Walle wrote:
> ---
>  urjtag/include/urjtag/bitops.h |   53
> ++++++++++++++++++++++++++++++++++++++++ 1 files changed, 53
> insertions(+), 0 deletions(-)
>  create mode 100644 urjtag/include/urjtag/bitops.h

this needs to be listed in the include/Makefile.am

> +inline uint16_t flip16 (uint16_t v);
> +inline uint32_t flip32 (uint32_t v);

these are useless decls considering you define the funcs right after

> +inline uint16_t flip16 (uint16_t v)
> +{
> +inline uint32_t flip32 (uint32_t v)
> +{

these need to be "static inline" if you're going to put them into headers

you also need to include stdint.h for the uint*_t types

> +        if (v & (1 << i)) out |= (1 << (15 - i));
> +        if (v & (1 << i)) out |= (1 << (31 - i));

two lines please
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

------------------------------------------------------------------------------
Start uncovering the many advantages of virtual appliances
and start using them to simplify application deployment and
accelerate your shift to cloud computing
http://p.sf.net/sfu/novell-sfdev2dev
_______________________________________________
UrJTAG-development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/urjtag-development

Reply via email to