On Thu, Jun 30, 2011 at 13:57, Jie Zhang wrote: > On Thu, Jun 30, 2011 at 10:58 AM, Mike Frysinger wrote: >> On Thu, Jun 30, 2011 at 09:51, Jie Zhang wrote: >>> Why your original code does not work? >> >> the changelog says why ... if you do `touch cmd_bfin.c`, then the >> cmd_list.h will always get generated on every `make`. >> >> i guess an alternative would be that if the list is unchanged, then do >> `touch -r cmd_list.h generated_cmd_list.h`. i didnt do that >> originally as i wanted to avoid portability issues, but i guess this >> syntax is in POSIX, so it should be fine. >> > This will not work for all cases. For example, when cmd_list.h is > older than some cmd C file, generated_cmd_list.h will be generated > again and again. > > I propose the attached patch. It should solve this issue. But it has a > minor issue. Touch cmd_bfin.c and make > > make[3]: Entering directory `/home/jie/sources/urjtag/git/urjtag/src/cmd' > GEN generated_cmd_list.h.stamp > generated_cmd_list.h is unchanged > CC cmd_bfin.lo > CCLD libcmd.la > make[3]: Leaving directory `/home/jie/sources/urjtag/git/urjtag/src/cmd' > > It's not ideally "GEN generated_cmd_list.h". I hope it's more > acceptable than the issues without this patch.
yeah, the downside of yours is not as bad as the downside of mine. this patch looks good to me, thanks ! -mike ------------------------------------------------------------------------------ All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 _______________________________________________ UrJTAG-development mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/urjtag-development
