this patch is named "0003-..." ... but your e-mail says 2/2 :) should all the strings passed to PyErr_SetString be wrapped in _() so that they can be localized ?
please use "if (" and not "if("
it's too bad you have to manually enumerate the urjtag funcs for python
modules. wouldnt swig do this for you ? or does that come with its own set
of problems and so we shouldnt bother ?
when you call fopen, please use the new FOPEN_R and FOPEN_W helper defines
(they come from sysdep.h) rather than "rb" and "wb" yourself.
otherwise, i dont have much to say. we can get this merged i think and let
people play with it and sort things out :).
-mike
signature.asc
Description: This is a digitally signed message part.
------------------------------------------------------------------------------ EMC VNX: the world's simplest storage, starting under $10K The only unified storage solution that offers unified management Up to 160% more powerful than alternatives and 25% more efficient. Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev
_______________________________________________ UrJTAG-development mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/urjtag-development
