On Sunday 01 January 2012 09:48:18 Márton Miklós wrote: > Yes you are right, I have converted them to macros. See > signal_helpers.patch.
i made them lower case (whether they're defines or inline funcs or external
funcs shouldn't matter to the caller) and committed that
> > however, i'd like to see some example bus cleanups before adding funcs
> > which are otherwise unused ...
>
> I have ran the following sed commands on the trunk svn rev. 2017:
>
> find . -iname '*c' -type f -exec sed -i 's/urj_part_set_signal
> (\([a-zA-Z0-9_]*\), \([a-zA-Z0-9_]*\), 0, 0);/URJ_PART_SET_SIGNAL_INPUT
> (\1, \2);/g' {} \;
> find . -iname '*c' -type f -exec sed -i 's/urj_part_set_signal
> (\([a-zA-Z0-9_]*\), \([a-zA-Z0-9_]*\), 0, 1);/URJ_PART_SET_SIGNAL_INPUT
> (\1, \2);/g' {} \;
> find . -iname '*c' -type f -exec sed -i 's/urj_part_set_signal
> (\([a-zA-Z0-9_]*\), \([a-zA-Z0-9_]*\), 1, 1);/URJ_PART_SET_SIGNAL_HIGH
> (\1, \2);/g' {} \;
> find . -iname '*c' -type f -exec sed -i 's/urj_part_set_signal
> (\([a-zA-Z0-9_]*\), \([a-zA-Z0-9_]*\), 1, 0);/URJ_PART_SET_SIGNAL_LOW
> (\1, \2);/g' {} \;
>
> If the code followed the coding convetions everywhere, all the
> occurrences should be replaced. See signal_helpers_applied.patch
that didn't catch all cases ;). i ran a more comprehensive sed on top of your
work and committed the result.
thanks!
-mike
signature.asc
Description: This is a digitally signed message part.
------------------------------------------------------------------------------ Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/
_______________________________________________ UrJTAG-development mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/urjtag-development
