On Sat, Aug 03, 2019 at 09:21:28PM +0200, [email protected] wrote:
> Geert Stappers:
> > On Sat, Aug 03, 2019 at 05:11:38PM +0200, Karl Hammar wrote:
> > >   urj_vhdl_set_entity() saved the entity name in the parts part_name.
> > >   Now that that bug is fixed, save the entity name as part_name if
> > >   the idcode matches for this file.
> ...
> > Rewrite the commit message into what just matches the change
> 
> Would:
> 
>       Save the entity name as part_name if    the idcode matches for this 
> file.
> 
> be ok ?
> 

No. Create commit message that make reading `git show` or `git log --patch` 
coherent.

Currently doesn't

Subject: Re: [UrJTAG-dev] [PATCH] fix bug in detect/bsdl

>       Save the entity name as part_name if    the idcode matches for this 
> file.


look coherent.  Current commit message without email clutter:

    fix bug in detect/bsdl

    Save the entity name as part_name if the idcode matches for this file.





Groeten
Geert Stappers
-- 
Leven en laten leven


_______________________________________________
UrJTAG-development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/urjtag-development

Reply via email to