On Wednesday 14 September 2005 23:18, Jeff Dike wrote: > On Wed, Sep 14, 2005 at 10:00:39PM +0200, Blaisorblade wrote: > > Assuming it can be done, it'd be ok. > > > > However, why have we already dequeued the request? > > It is easier than removing segments from the request and finally > dequeueing the request when it is finally empty. Why can't you just move that exact call later, without removing segments?
However, even if it's "easier" this way, IMHO it's still easier to defer the removal than to readd the thing into the queue (assuming the driver is supposed to do this). Not that I've looked well at the code or at the API recently. I'm busy with other stuff. > > Looking for examples, via grep blkdev_dequeue_request drivers/ide/*.c and > > going opening drivers/ide/ide-io.c, I found blkdev_dequeue_request() > > called *after* end_that_request_first(), while there it's called before. > > A comment in blk_start_pre_flush() says there's some freedom, but > > probably leaving the request in the queue would be ok.... > There is a good amount of freedom. The driver is given a set of > requests, and has the job of making them happen. > Jeff -- Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!". Paolo Giarrusso, aka Blaisorblade (Skype ID "PaoloGiarrusso", ICQ 215621894) http://www.user-mode-linux.org/~blaisorblade ___________________________________ Yahoo! Mail: gratis 1GB per i messaggi e allegati da 10MB http://mail.yahoo.it ------------------------------------------------------- SF.Net email is sponsored by: Tame your development challenges with Apache's Geronimo App Server. Download it for free - -and be entered to win a 42" plasma tv or your very own Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php _______________________________________________ User-mode-linux-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
