On Sun, Oct 29, 2006 at 08:20:29PM +0100, Paolo 'Blaisorblade' Giarrusso wrote: > From: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> > > and then call any "struct ubd" ubd_dev instead of dev, which doesn't > make clear what we're treating (and no, it's not hungarian notation - > not any more than calling all vm_area_struct vma or all inodes > inode).
I can't say that I like this part of it. I don't see any alternate interpretation of a variable called 'dev', and renaming it to 'ubd_dev' seems redundant, given that we are in the ubd driver. Plus, this change sent a couple of lines over the 80-character boundary. Jeff Work email - jdike at linux dot intel dot com ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel