On 29 Nov 2006, [EMAIL PROTECTED] verbalised: > On Sunday 26 November 2006 22:02, Nix wrote: >> However, other problems are so-far undescribed. There's one trivial one >> (fixed in patch 3 in this series, should be uncontroversial). > Agreed.
Oh good, that's the only one I was confident of. >> And then there's this: >> >> CC arch/um/os-Linux/process.o >> In file included from arch/um/include/skas_ptrace.h:12, >> from arch/um/os-Linux/process.c:23: >> arch/um/include/sysdep/skas_ptrace.h:9: error: redefinition of `struct >> ptrace_faultinfo' arch/um/include/sysdep/skas_ptrace.h:14: error: >> redefinition of `struct ptrace_ldt' > >> The problem is that I installed my host kernel's headers, and that >> kernel has the skas patch installed, so the skas ptrace structures >> are already defined in <asm/ptrace.h>. Thankfully it's guarded by a >> #define that we can test, but even so we need to split that SKAS >> section out into a new header. (diff attached, not gitted since >> the SKAS part isn't maintained in git anyway.) > >> So the following patches are a terribly provisional way to fix this: >> it works but it may not maintain the separation between skas and >> mainline that you want. > > You maybe refer to the problem that without SKAS in host headers the > resulting > UML tree does not compile? I *have* SKAS in the host headers. That's the problem (and it arguably shouldn't be). > Yes, it is a problem. You are trying to remove > all > duplications, and probably you should avoid them. Define a macro to test with > a more reasonable name (say __UML_SKAS_SUPPORT ...). OK, will do. I just thought that cutting the skas-ptrace stuff into its own header, rather than duplicating pieces of it between arch/ and include/um/, seemed more immediately reasonable. -- `The main high-level difference between Emacs and (say) UNIX, Windows, or BeOS... is that Emacs boots quicker.' --- PdS ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
