On Mon, 28 Apr 2008, Jeff Dike wrote:
> On Sat, Apr 26, 2008 at 05:17:55PM +0800, WANG Cong wrote:
>> > +static struct inode *get_inode(struct super_block *, struct dentry *);
>> > +
>> > +struct hppfs_data {
>> > + struct list_head list;
>> > + char contents[PAGE_SIZE - sizeof(struct list_head)];
>> > +};
>> > +
>> > +struct hppfs_private {
>> > + struct file *proc_file;
>> > + int host_fd;
>> > + loff_t len;
>> > + struct hppfs_data *contents;
>> > +};
>> > +
>> > +struct hppfs_inode_info {
>> > + struct dentry *proc_dentry;
>> > + struct inode vfs_inode;
>> > +};
>> > +
>> > +static inline struct hppfs_inode_info *HPPFS_I(struct inode *inode)
>> > +{
>> > + return container_of(inode, struct hppfs_inode_info, vfs_inode);
>> > +}
>> > +
>> > +#define HPPFS_SUPER_MAGIC 0xb00000ee
>>
>>
>> These can be put into a single header, e.g. hppfs.h.
>
> Why, when this one C file is the only user?
Just looks cleaner for me. ;-)
<snip>
>
> Oops, nice spotting.
>
> See what you think about the patch below...
<snip>
This patch looks OK for me. Thank you!
Cong
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
