On Tuesday 10 November 2009 07:50:21 Tobias Brunner wrote:
> When setting the timestamps of a file using e.g. futimens the flag
> HOSTFS_ATTR_(A|M)TIME_SET is set only if explicit timestamps were
> specified. If futimens is called without timestamps (i.e. parameter
> times is set to NULL), only HOSTFS_ATTR_(A|M)TIME is set. On the other
> hand, the latter flag is also set if the timestamps were explicitly
> specified.
>
> Signed-off-by: Tobias Brunner <tob...@strongswan.org>
I hit this bug too, and this patch fixed it for me, so:
Acked-by: Rob Landley <r...@landley.net>
Speaking of which, here's a pending patch of my own reparented on top of this
one:
From: Rob Landley <r...@landley.net>
Switch futimes() usage to Posix 2008 futimens(), and while I'm at migrate
utimes() to utimensat() and eliminate use of timeval.
This is required to build UML against uClibc.
Signed-off-by: Rob Landley <r...@landley.net>
---
fs/hostfs/hostfs_user.c | 32 +++++++++++++++++---------------
1 file changed, 17 insertions(+), 15 deletions(-)
--- temp2/fs/hostfs/hostfs_user.c 2009-11-22 17:52:21.000000000 -0600
+++ temp/fs/hostfs/hostfs_user.c 2009-11-29 05:51:57.000000000 -0600
@@ -3,6 +3,12 @@
* Licensed under the GPL
*/
+/* These two #defines are needed for futimens and utimensat until glibc
+ catches up with posix 2008. */
+
+#define __USE_ATFILE
+#define __USE_GNU
+
#include <stdio.h>
#include <stddef.h>
#include <unistd.h>
@@ -235,8 +241,7 @@
int set_attr(const char *file, struct hostfs_iattr *attrs, int fd)
{
- struct timeval times[2];
- struct timespec atime_ts, mtime_ts;
+ struct timespec time_ts[2];
int err, ma;
if (attrs->ia_valid & HOSTFS_ATTR_MODE) {
@@ -280,29 +285,26 @@
ma = (HOSTFS_ATTR_ATIME | HOSTFS_ATTR_MTIME);
if (attrs->ia_valid & ma) {
err = stat_file(file, NULL, NULL, NULL, NULL, NULL, NULL,
- &atime_ts, &mtime_ts, NULL, NULL, NULL, fd);
+ time_ts, time_ts+1, NULL, NULL, NULL, fd);
if (err != 0)
return err;
- times[0].tv_sec = atime_ts.tv_sec;
- times[0].tv_usec = atime_ts.tv_nsec / 1000;
- times[1].tv_sec = mtime_ts.tv_sec;
- times[1].tv_usec = mtime_ts.tv_nsec / 1000;
-
if (attrs->ia_valid & HOSTFS_ATTR_ATIME) {
- times[0].tv_sec = attrs->ia_atime.tv_sec;
- times[0].tv_usec = attrs->ia_atime.tv_nsec / 1000;
+ time_ts[0].tv_sec = attrs->ia_atime.tv_sec;
+ time_ts[0].tv_nsec = attrs->ia_atime.tv_nsec;
}
if (attrs->ia_valid & HOSTFS_ATTR_MTIME) {
- times[1].tv_sec = attrs->ia_mtime.tv_sec;
- times[1].tv_usec = attrs->ia_mtime.tv_nsec / 1000;
+ time_ts[1].tv_sec = attrs->ia_mtime.tv_sec;
+ time_ts[1].tv_nsec = attrs->ia_mtime.tv_nsec;
}
if (fd >= 0) {
- if (futimes(fd, times) != 0)
+ if (futimens(fd, time_ts) != 0)
return -errno;
- } else if (utimes(file, times) != 0) {
- return -errno;
+ } else {
+ if (utimensat(AT_FDCWD, file, time_ts, 0) != 0) {
+ return -errno;
+ }
}
}
--
Latency is more important than throughput. It's that simple. - Linus Torvalds
------------------------------------------------------------------------------
Return on Information:
Google Enterprise Search pays you back
Get the facts.
http://p.sf.net/sfu/google-dev2dev
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
