[[PATCH] um, x86: Fix vDSO build] On 12/01/2014 (Sun 15:52) Richard Weinberger wrote:
> Commit "x86: Delete non-required instances of include <linux/init.h>" > broke the UML build. > > arch/x86/um/vdso/vdso.S: Assembler messages: > arch/x86/um/vdso/vdso.S:2: Error: no such instruction: `__initdata' > arch/x86/um/vdso/vdso.S:9: Error: no such instruction: `__finit' > > UML's vDSO needs linux/init.h. > > Signed-off-by: Richard Weinberger <rich...@nod.at> Thanks Richard & Ingo. I did these cleanups last fall but never got around to submitting them until now; I think the false positives for removal crept in when I manually started the process, before realizing the scale of it needed automatic selection/application and verification. And without me doing uml testing, I never got a chance to see the breakage and undo it. I'll definitely add uml to my regular testing. I see hpa has already put this on x86/cleanups, but for the record: Acked-by: Paul Gortmaker <paul.gortma...@windriver.com> Thanks again and sorry for the inconvenience. P. -- > --- > arch/x86/um/vdso/vdso.S | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/x86/um/vdso/vdso.S b/arch/x86/um/vdso/vdso.S > index 4b4bd4c..1cb468a 100644 > --- a/arch/x86/um/vdso/vdso.S > +++ b/arch/x86/um/vdso/vdso.S > @@ -1,3 +1,4 @@ > +#include <linux/init.h> > > __INITDATA > > -- > 1.8.1.4 > ------------------------------------------------------------------------------ CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments & Everything In Between. Get a Quote or Start a Free Trial Today. http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
