> <snip> Hi Thomas,
Could you please fix your patch since there are multiple issues with it 1) I does not apply cleanly against the current linux tree mostly due to kmsg_dump.c which is not in the proper format it should be b/arch/um/kernel/kmsg_dump.c like the rest of the patch 2) After fixing this it did not build Please make sure to build test your patch on a fresh checkout of the tree by applying your patch, make ARCH=um mrproper, make ARCH=um defconfig make ARCH=um 3) The patch itself does not comply to patch standards. please read Documentation/SubmittingPatches for more information you can use scripts/checkpatch.pl to check for common errors eg: Signed-off-by is missing, etc. Now that we're done with the non-technical things, I don't like a) that you move the inline function (current_thread_info) out of the header file b) introduce a branch into this function which is most likely never taken (you could use if (unlikely(!is_kernel_addr((void *)ti)) ) c) I'd personally would make is_kernel_addr either an inline function or a macro d) please split up the 2 changes in to different patches 1) return init_thread_info if not kernel_addr 2) add kmsg_dumper to panic_exit() e) I'm not sure if returning init_thread_info is the right approach, it might mask other errors like memory corruption bugs, etc. I do like the kmsg_dumper thing, so would you mind sending this as a separate patch ? Cheers, Daniel ------------------------------------------------------------------------------ Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
