đź‘Ť
Best Regards. Jia Zhai Beijing, China Mobile: +86 15810491983 On Wed, Nov 4, 2020 at 12:19 AM Enrico Olivelli <eolive...@gmail.com> wrote: > FYI > Latest BK image is now running on OpenJDK11 by default > docker run apache/bookkeeper:latest > > The same will be for BK 4.12, but in BK 4.12 we are able to also support > JRE distribution and not full JDK. > > Enrico > > Il giorno ven 23 ott 2020 alle ore 22:06 Enrico Olivelli < > eolive...@gmail.com> ha scritto: > > > > > > > Il Ven 23 Ott 2020, 18:57 Anup Ghatage <ghat...@gmail.com> ha scritto: > > > >> So I've been trying something similar. > >> > >> I noticed that most of the Bookkeeper codebase can build with JDK8 and > >> JDK11. > >> So I hacked around a bit and found that if I compile BK using JDK8, > reset > >> JAVA_HOME to JDK11 and use 'mvn surefire:test', it just runs the tests > >> without compilation. > >> In this way, all of our unit tests run on JDK11 while being compiled on > >> JDK8. We already have 78% + coverage from unit tests which means that > 78%+ > >> code base will have no problems. > >> > >> When it comes to runtime, most obvious problems running on JDK11 are > most > >> of the JDK8 GC options which have been retired so we can have scripts > >> which > >> deploy differently for different underlying JDK versions. > >> > >> Since we can run JDK8 compiled bits on JDK11, we could propose a phased > >> approach. > >> For the next two releases, ship both JDK8 and JDK11. Post that, we can > >> fully move to JDK11 for compilation and runtime. > >> > > > > We have been running Bookies and BK clients on JDK9-15 without issues. > > Also BK scripts support jdk11 and from 4.12 we will be also supporting > > JRE11+. > > > > > > Personally I would prefer to stay on bytecode compiled for JDK8, until we > > hit a time in which supporting it would be too costly. > > > > In HerdDB we are using multi release har in order to leverage modern jdk > > features (like new array comparisons, hotspot intrinsics). > > We could have this approach for CRC32C as well. > > > > IIRC we are also running a CI pull validation action with JDK11 > > > > Enrico > > > > > > > >> Regards, > >> Anup > >> > >> > >> > >> > >> On Wed, Oct 21, 2020 at 11:49 PM Alessandro Luccaroni - Diennea > >> <alessandro.luccar...@diennea.com.invalid> wrote: > >> > >> > Hi, > >> > for the sake of the ZK project I hope they don’t go down that route > >> (I’ve > >> > already exposed my concern on the ZK mailing list) since there are > many > >> > application in the wild that will be stuck on an older version of ZK. > >> > > >> > From my own company point of view we already support Java11 in all our > >> > applications so we are not directly impacted (and we have upgrade path > >> for > >> > older versions to provide to our customers). > >> > Since BK is a much younger project I don’t expect that the move to > >> Java11 > >> > will be a problem. I think that Pulsar still supports Java8. > >> > > >> > Even in the case that the ZK team will decide to not go down that > route > >> > (and still maintain Java8 support) I think that we should plan that > move > >> > for BK to prevent a similar situation in the future (naturally, as > soon > >> as > >> > Pulsar will drop support for Java8). > >> > > >> > Alessandro Luccaroni > >> > Platform Manager @ Diennea - MagNews > >> > Tel.: (+39) 0546 066100 Int. 924 - Mob.: (+39) 393 7273519 > >> > Viale G.Marconi 30/14 - 48018 Faenza (RA) - Italy > >> > > >> > Da: Enrico Olivelli <eolive...@gmail.com> > >> > Inviato: mercoledì 21 ottobre 2020 11:24 > >> > A: Bookkeeper-Dev <d...@bookkeeper.apache.org>; user < > >> > user@bookkeeper.apache.org> > >> > Oggetto: Moving BooKeeper to JDK11 > >> > > >> > Hello guys, > >> > (crossposting to user and dev) > >> > In the ZooKeeper project there is an open discussion about moving > >> > ZooKeeper 3.7 to JDK11 and basically dropping support for JDK8 in the > >> > client. > >> > > >> > If they go that route we will probably need to move in the same > >> direction. > >> > > >> > How do you feel about this? > >> > Is JDK8 still required for your applications ? > >> > > >> > Best regards > >> > Enrico > >> > > >> > > >> > ________________________________ > >> > > >> > CONFIDENTIALITY & PRIVACY NOTICE > >> > This e-mail (including any attachments) is strictly confidential and > may > >> > also contain privileged information. If you are not the intended > >> recipient > >> > you are not authorised to read, print, save, process or disclose this > >> > message. If you have received this message by mistake, please inform > the > >> > sender immediately and destroy this e-mail, its attachments and any > >> copies. > >> > Any use, distribution, reproduction or disclosure by any person other > >> than > >> > the intended recipient is strictly prohibited and the person > responsible > >> > may incur in penalties. > >> > The use of this e-mail is only for professional purposes; there is no > >> > guarantee that the correspondence towards this e-mail will be read > only > >> by > >> > the recipient, because, under certain circumstances, there may be a > >> need to > >> > access this email by third subjects belonging to the Company. > >> > > >> > >> > >> -- > >> Anup Ghatage > >> www.ghatage.com > >> > > >