Thanks! I feel the same. I am using Java 5, and I do not see any performance issue yet, but it just bother other engineers when they see the code. I look at the source, the 2 main vars will be used are
this.sizeThreshold = sizeThreshold; this.repository = repository; They are passed in the createItem method. I believe as long as I do not need dynamically to change the sizeThreshold and repository, the factory object can be static. -- View this message in context: http://n4.nabble.com/Is-DiskFileItemFactory-Thread-Safe-tp1469216p1469816.html Sent from the Commons - User mailing list archive at Nabble.com. --------------------------------------------------------------------- To unsubscribe, e-mail: user-unsubscr...@commons.apache.org For additional commands, e-mail: user-h...@commons.apache.org